[mythtv-commits] [MythTV/mythtv] 45aca1: cppcheck: Clean up "parameter should passed as a c...

[linuxdude42]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 45aca1e8efd55b5a6bdb58ac09e8736dc44cc08e
      https://github.com/MythTV/mythtv/commit/45aca1e8efd55b5a6bdb58ac09e8736dc44cc08e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythbase/hardwareprofile.cpp
    M mythtv/libs/libmythbase/hardwareprofile.h
    M mythtv/libs/libmythbase/iso639.cpp
    M mythtv/libs/libmythbase/iso639.h
    M mythtv/libs/libmythbase/mythcommandlineparser.h
    M mythtv/libs/libmythbase/mythlocale.cpp
    M mythtv/libs/libmythbase/mythlocale.h
    M mythtv/libs/libmythbase/mythsorthelper.cpp
    M mythtv/libs/libmythbase/mythsorthelper.h
    M mythtv/libs/libmythbase/mythstorage.cpp
    M mythtv/libs/libmythbase/mythstorage.h
    M mythtv/libs/libmythui/screensaver-dbus.cpp

  Log Message:
  -----------
  cppcheck: Clean up "parameter should passed as a const reference" messages.


  Commit: cff08e3f13f994d2faec1c35cd89b75ba0583ce9
      https://github.com/MythTV/mythtv/commit/cff08e3f13f994d2faec1c35cd89b75ba0583ce9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythbase/mythsorthelper.h

  Log Message:
  -----------
  cppcheck: Clean up "one argument constructor not explicit" message.


  Commit: 0823653b4390d7b01d36bf8a88851df696ee34b3
      https://github.com/MythTV/mythtv/commit/0823653b4390d7b01d36bf8a88851df696ee34b3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythui/AppleRemote.h
    M mythtv/libs/libmythui/screensaver-android.h
    M mythtv/libs/libmythui/screensaver-osx.h

  Log Message:
  -----------
  cppcheck: Clean up "not marked with a 'override' specifier" messages.


  Commit: 3ee127de7a0ce643a5db283c3095d137ab8b49b8
      https://github.com/MythTV/mythtv/commit/3ee127de7a0ce643a5db283c3095d137ab8b49b8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-02-26 (Tue, 26 Feb 2019)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/pls.cpp
    M mythtv/libs/libmythbase/codecutil.cpp
    M mythtv/libs/libmythbase/mythsystem.cpp
    M mythtv/libs/libmythbase/portchecker.cpp
    M mythtv/libs/libmythtv/recorders/RTjpegN.cpp
    M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
    M mythtv/programs/mythtv-setup/checksetup.cpp

  Log Message:
  -----------
  cppcheck: Clean up "variable assigned a value that is never used" messages.

Mostly removing the variable assignment.  In one case the value is
assigned from a function call, one of the other parameters is a return
value and is used, so just quiet the warning.  In another case the
variable is only used inside of an ifdef, so declare the variable in
an ifdef.


Compare: https://github.com/MythTV/mythtv/compare/5b6384689994...3ee127de7a0c