[mythtv-commits] [MythTV/mythtv] 6fc3d1: PrivateDecoderOMX: Consistent frame heights

[Mark Kendall]

  Branch: refs/heads/devel/2019-render
  Home:   https://github.com/MythTV/mythtv
  Commit: 6fc3d131e5fbfab7f4469594a0f402a113442cc4
      https://github.com/MythTV/mythtv/commit/6fc3d131e5fbfab7f4469594a0f402a113442cc4
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-02-10 (Sun, 10 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythtv/privatedecoder_omx.cpp

  Log Message:
  -----------
  PrivateDecoderOMX: Consistent frame heights

- the openmax decoder outputs 'rounded' frame heights but the stream
parser picks up the full coded height e.g. 1088 height frames are
returned with a height of 1080
- this is fine in theory - unless the renderer is looking for a change in
the actual frame dimensions to trigger a reset...
- so make the frame heights consistent with the other decoders/parsers.


  Commit: b8e9aab852b9b3a34535a4230d586b3152993925
      https://github.com/MythTV/mythtv/commit/b8e9aab852b9b3a34535a4230d586b3152993925
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythtv/avformatdecoder.cpp
    M mythtv/libs/libmythtv/libmythtv.pro
    M mythtv/libs/libmythtv/mythopenglinterop.cpp
    M mythtv/libs/libmythtv/mythopenglinterop.h
    M mythtv/libs/libmythtv/openglvideo.cpp
    M mythtv/libs/libmythtv/openglvideo.h
    M mythtv/libs/libmythtv/vaapicontext.cpp
    M mythtv/libs/libmythtv/videoout_opengl.cpp
    M mythtv/libs/libmythtv/videoout_opengl.h
    R mythtv/libs/libmythtv/videoout_openglvaapi.cpp
    R mythtv/libs/libmythtv/videoout_openglvaapi.h
    M mythtv/libs/libmythtv/videooutbase.cpp
    M mythtv/libs/libmythui/mythrender_opengl.cpp
    M mythtv/libs/libmythui/mythrender_opengl.h

  Log Message:
  -----------
  VideoOutputOpenGLVAAPI: Remove

- merge remaining code back into VideoOutputOpenGL
- there are still a few gotchas (all existing, not resulting from this
commit)
-- fallback to regular OpenGL output doesn't yet work when using, for
example, eglfs. It fails early and bails out.
-- deinterlacing setup is a mess. The whole thing needs refactoring now
that we have deinterlacing in the decoder as well.
-- need to add additional capability checks when intitialising the
FFmpeg hardware context. The current check does not account for codecs
that are actually unsupported by libva (e.g. mpeg4) - or indeed frame
sizes etc.
-- this leads to unnecessary multiple attempts at starting accelerated
decoding before falling back to software version.


  Commit: a21132ca6b83ed669d6a04aaa98bab1005e62264
      https://github.com/MythTV/mythtv/commit/a21132ca6b83ed669d6a04aaa98bab1005e62264
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M mythtv/libs/libmythtv/avformatdecoder.cpp
    M mythtv/libs/libmythtv/mythopenglinterop.cpp
    M mythtv/libs/libmythtv/vaapicontext.cpp
    M mythtv/libs/libmythtv/vaapicontext.h

  Log Message:
  -----------
  VAAPIContext: Add a comprehensive hardware support check

- FFmpeg doesn't actually check for hardware support at all - which
causes late decoder failures and adds a significant delay while the
decoder classes work through their issues.
- on the upside, this exposes the surface formats supported by the VAAPI
implementation which will ease adding 10bit support.


Compare: https://github.com/MythTV/mythtv/compare/0b5f33ae2d5a...a21132ca6b83