[mythtv-commits] Ticket #13542: Feature patch - qmake .pro file modernization for various non-app directories

MythTV noreply at mythtv.org
Mon Dec 23 17:57:05 UTC 2019


#13542: Feature patch - qmake .pro file modernization for various non-app
directories
----------------------------------+--------------------------
     Reporter:  Gary Buhrmaster   |      Owner:  (none)
         Type:  Patch - Feature   |     Status:  new
     Priority:  minor             |  Milestone:  needs_triage
    Component:  MythTV - General  |    Version:  Master Head
     Severity:  medium            |   Keywords:
Ticket locked:  0                 |
----------------------------------+--------------------------
 Feature patch - qmake .pro file modernization for various non-app
 directories

 Change qmake TEMPLATE to aux (from app) for directories that do not build
 anything (and remove app template artifacts).

 The aux template was added in QT5.  Per the docs the aux template "Creates
 a Makefile for not building anything. Use this if no compiler needs to be
 invoked to create the target" which is exactly what we want for these
 directories.

 The patch was mostly mechanical (update the .pro file, remove the dummy.c
 source file).

 *SPECIAL NOTE* These updates should arguably also update the .gitignore
 files in the respective directories to no longer exclude the target binary
 (created from dummy.c), but to remove that target binary would require
 every developer to run a make clean/distclean before pulling the commit to
 avoid the possibility of accidentally adding that (now leftover) binary
 into the project at some future commit.  As the cost of the .gitignore
 entry is small, I made the choice to not update .gitignore in the
 directories.  If the committer is confident that there will be no
 confusion, removing (or emptying the contents of) the .gitignore from the
 impacted directories can be performed.  Caveat Emptor.

 Patch attached.

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13542>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list