[mythtv-commits] [MythTV/mythtv] d42520: Eliminate warning messages in libmythdvdnav.

[linuxdude42]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: d425200e56e1c1145cda03d31b3faeb4561a840d
      https://github.com/MythTV/mythtv/commit/d425200e56e1c1145cda03d31b3faeb4561a840d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-04-23 (Tue, 23 Apr 2019)

  Changed paths:
    M mythtv/external/libmythdvdnav/dvdread/dvdread/ifo_types.h

  Log Message:
  -----------
  Eliminate warning messages in libmythdvdnav.

The 'gcc_struct' attribute only has meaning on a windows system, and
other compilers are starting to complain about it.  Restrict that
attribute to a windows compile.


  Commit: b02bba4b9b2de2f8e98026d9570db4d1003585cf
      https://github.com/MythTV/mythtv/commit/b02bba4b9b2de2f8e98026d9570db4d1003585cf
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-04-23 (Tue, 23 Apr 2019)

  Changed paths:
    M mythtv/libs/libmythtv/avformatdecoder.cpp
    M mythtv/libs/libmythtv/cardutil.cpp

  Log Message:
  -----------
  Eliminate unused variable/function warnings on android.


  Commit: 1593c82103b10c4243e18de00469c5881e9399cb
      https://github.com/MythTV/mythtv/commit/1593c82103b10c4243e18de00469c5881e9399cb
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-04-23 (Tue, 23 Apr 2019)

  Changed paths:
    M mythtv/libs/libmythbase/test/test_mythsystem/test_mythsystem.h
    M mythtv/libs/libmythbase/test/test_mythsystemlegacy/test_mythsystemlegacy.h

  Log Message:
  -----------
  Add delay to handle race condition in FreeBSD testing.

Calls to read the data output by the shell generate an EBADF error.
Apparently FreeBSD is fast enough that the file descriptors have often
been closed and cleaned up before the test code tries to read from
them.  Add a one second delay after output so that stdout and stderr
can be read consistently.


  Commit: b3e9db8c06c90f81fb7a430679a14b4271e8dc7b
      https://github.com/MythTV/mythtv/commit/b3e9db8c06c90f81fb7a430679a14b4271e8dc7b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-04-23 (Tue, 23 Apr 2019)

  Changed paths:
    M mythtv/libs/libmythbase/test/test_mythtimer/test_mythtimer.h

  Log Message:
  -----------
  Lengthen timers in test_mythtimer.

This allows some slop for build systems being busy while the tests are
running, but still keeps the same ratio of the timers so the test
should still be valid.


  Commit: a19188bfc9012ddc7d2c476f234bc1acaa904670
      https://github.com/MythTV/mythtv/commit/a19188bfc9012ddc7d2c476f234bc1acaa904670
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-04-23 (Tue, 23 Apr 2019)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutput.h
    M mythtv/libs/libmyth/audio/audiooutputsettings.h
    M mythtv/libs/libmythbase/referencecounterlist.h
    M mythtv/libs/libmythfreemheg/BaseClasses.h
    M mythtv/libs/libmythui/mythuiguidegrid.h
    M mythtv/programs/mythfrontend/videoplayercommand.cpp

  Log Message:
  -----------
  Fix a handful of new gcc9 "implicitly-declared <blah> is deprecated" warnings.

These warnings now occur when an object has a custom destructor but
not a copy constructor or a custom operator= function.  The thought is
that the custom destructor was probably written to free memory managed
by the object, and that the default copy constructor and operator=
function will simply copy the pointer value from one object to the
other.  That is a setup for an invalid memory reference to occur after
the first of the two objects is destroyed.

One of the functions fixed here need to copy memory as part of its
copy constructor and operator= functions.  There's already a copy
function available on the object, so use that.  The rest of the
functions fixed by this patch can simply declare that the default copy
constructor is sufficient.


Compare: https://github.com/MythTV/mythtv/compare/a7f4441f7156...a19188bfc901