[mythtv-commits] Ticket #13314: Build error in libavcodec with newer x264 versions

[MythTV]

#13314: Build error in libavcodec with newer x264 versions
--------------------------------------+---------------------------
     Reporter:  Frank Phillips        |      Owner:  Peter Bennett
         Type:  Bug Report - General  |     Status:  new
     Priority:  minor                 |  Milestone:  needs_triage
    Component:  3rd Party - FFMPEG    |    Version:  v29.1
     Severity:  medium                |   Keywords:
Ticket locked:  0                     |
--------------------------------------+---------------------------
 I recently upgraded from x264 version 152 to 155 and got this error:
 {{{
 libavcodec/libx264.c: In function ‘X264_frame’:
 libavcodec/libx264.c:282:9: error: ‘x264_bit_depth’ undeclared (first use
 in this function); did you mean ‘x264_picture_t’?
      if (x264_bit_depth > 8)
          ^~~~~~~~~~~~~~
          x264_picture_t
 libavcodec/libx264.c:282:9: note: each undeclared identifier is reported
 only once for each function it appears in
 libavcodec/libx264.c: In function ‘X264_init_static’:
 libavcodec/libx264.c:892:9: error: ‘x264_bit_depth’ undeclared (first use
 in this function); did you mean ‘x264_picture_t’?
      if (x264_bit_depth == 8)
          ^~~~~~~~~~~~~~
          x264_picture_t
 CC      libavcodec/lossless_audiodsp.o
 make[2]: *** [/build/mythtv-fixes-
 git/src/mythtv/mythtv/external/FFmpeg/common.mak:60: libavcodec/libx264.o]
 Error 1
 make[2]: *** Waiting for unfinished jobs....
 make[2]: Leaving directory '/build/mythtv-fixes-
 git/src/mythtv/mythtv/external/FFmpeg'
 make[1]: *** [Makefile:32: FFmpeg-all] Error 2
 make[1]: Leaving directory '/build/mythtv-fixes-
 git/src/mythtv/mythtv/external'
 make: *** [Makefile:67: external] Error 2

 }}}

 Upstream bug and fix: https://trac.ffmpeg.org/ticket/6932

 Arch Linux MythTV users (including myself) are using a similar patch:
 https://gist.githubusercontent.com/emerkle826/5a4302abfb09b9b3a4fed598bf3a1538/raw/4d8c178c44e4ec692c86a4516ec5e49e1f93dabf/libx264.patch

 I believe master is unaffected due to ffmpeg resyncs.

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13314>
MythTV <http://www.mythtv.org>
MythTV Media Center