[mythtv-commits] Ticket #13335: mythcommflag: add 3 settings to enhance logo detection

[MythTV]

#13335: mythcommflag: add 3 settings to enhance logo detection
-----------------------------------+------------------------------
 Reporter:  hamelg                 |          Owner:  cpinkham
     Type:  Patch - Feature        |         Status:  new
 Priority:  minor                  |      Milestone:  needs_triage
Component:  MythTV - Mythcommflag  |        Version:  Master Head
 Severity:  medium                 |     Resolution:
 Keywords:                         |  Ticket locked:  0
-----------------------------------+------------------------------

Comment (by warpme):

 Ok, I merged all commflag sources from Your gha-debug to current master
 and recompile.

 DB settings seems to be OK (IMHO)


 {{{
 mysql> select * from settings where value like "CommDetect%";
 +---------------------------------+------+----------+
 | value                           | data | hostname |
 +---------------------------------+------+----------+
 | CommDetectLogoBorder            | 64   | NULL     |
 | CommDetectLogoGoodEdgeThreshold | 0.80 | NULL     |
 | CommDetectLogoHeightRatio       | 8    | NULL     |
 | CommDetectLogoLocation          | NE   | NULL     |
 | CommDetectLogoSamplesNeeded     | 240  | NULL     |
 | CommDetectLogoSampleSpacing     | 15   | NULL     |
 | CommDetectLogoWidthRatio        | 6    | NULL     |
 | CommDetectMaxCommBreakLength    | 660  | mythtv   |
 +---------------------------------+------+----------+
 8 rows in set (0.00 sec)

 }}}

 Next I launched commflag on 1080i test recording
 (first 100MB of test recording is here http://warped.inet2.org/sample8.ts)

 {{{
 [root at mythtv log]# mythcommflag --skipdb --file
 /myth/tv/23809_20181025181500.ts --method logo --outputmethod full
 --outputfile -
 MythTV Commercial Flagger, flagging commercials for:
     /myth/tv/23809_20181025181500.ts
 2018-10-30 09:48:23.940451 C  mythcommflag version: (HEAD detached from
 33e31a0) [v30-Pre-910-g1af2764-dirty-v9.7.3.debug] www.mythtv.org
 2018-10-30 09:48:23.940494 C  Qt version: compile: 5.5.1, runtime: 5.5.1
 2018-10-30 10:04:16.212022 E  decoding error End of file (-541478725)
 commercialBreakListFor: /myth/tv/23809_20181025181500.ts
 totalframecount: 149600
   frame     min/max/avg scene aspect format flags mark
          1:  -1/ -1/ -1  -1%   wide  normal blank
          2:  -1/ -1/ -1  -1%   wide  normal blank
          3:  -1/ -1/ -1  -1%   wide  normal blank
          4:  -1/ -1/ -1  -1%   wide  normal blank
          5:  -1/ -1/ -1  -1%   wide  normal blank
          6:  -1/ -1/ -1  -1%   wide  normal blank
          7:  -1/ -1/ -1  -1%   wide  normal blank
          8:  -1/ -1/ -1  -1%   wide  normal blank
          9:  -1/ -1/ -1  -1%   wide  normal blank
         10:  -1/ -1/ -1  -1%   wide  normal blank
         11:  -1/ -1/ -1  -1%   wide  normal blank
         12:  -1/ -1/ -1  -1%   wide  normal blank
         13:  -1/ -1/ -1  -1%   wide  normal blank
         14:  -1/ -1/ -1  -1%   wide  normal blank
         15:  -1/ -1/ -1  -1%   wide  normal blank
         16:  -1/ -1/ -1  -1%   wide  normal blank
         17:  -1/ -1/ -1  -1%   wide  normal blank
         18:  -1/ -1/ -1  -1%   wide  normal blank
         19:  -1/ -1/ -1  -1%   wide  normal blank
         20:  -1/ -1/ -1  -1%   wide  normal blank
         21:  -1/ -1/ -1  -1%   wide  normal blank
         22:  -1/ -1/ -1  -1%   wide  normal blank
         23:  -1/ -1/ -1  -1%   wide  normal blank
         24:  -1/ -1/ -1  -1%   wide  normal blank
         25:  -1/ -1/ -1  -1%   wide  normal blank
         26:  -1/ -1/ -1  -1%   wide  normal blank
         27:  -1/ -1/ -1  -1%   wide  normal blank
         28:  -1/ -1/ -1  -1%   wide  normal blank
         29:  -1/ -1/ -1  -1%   wide  normal blank
         30:  -1/ -1/ -1  -1%   wide  normal blank
         and many more lines of such error
 }}}

 this "-1" errors I have also with unpatched commflag - so I suspect issue
 is maybe ffmpeg resync related.
 I'm curious what Your's commflag will show on this recording....

 By curiosity I tried patched commflag on 576i recording and results are
 the same :-(

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13335#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center