[mythtv-commits] Ticket #13335: mythcommflag: add 3 settings to enhance logo detection

[MythTV]

#13335: mythcommflag: add 3 settings to enhance logo detection
-----------------------------------+------------------------------
 Reporter:  hamelg                 |          Owner:  cpinkham
     Type:  Patch - Feature        |         Status:  new
 Priority:  minor                  |      Milestone:  needs_triage
Component:  MythTV - Mythcommflag  |        Version:  Master Head
 Severity:  medium                 |     Resolution:
 Keywords:                         |  Ticket locked:  0
-----------------------------------+------------------------------

Comment (by warpme):

 Well - lest synchronise terminology:

 what you mentioned as "in mater" isn't master in terminology mythtv devs
 nor me nor mythtv users.

 It should be called "my repo branch master".
 If You want to successfully include Your PR to myth code, it should:

 1.pass some testing on _official_ myth code base

 2.review with myth devs regarding myth coding standards+implementatoin
 correctnes (i.e. nor leading to regressions in other parts of code)

 You are now in pahse1

 While I understand that in development phase it might be easier to do
 thing initially on developer fork - but if development is engaging time of
 other persons - good collaboration requires proper communication..
 .
 Since our last few exchanges I'm feeling constantly like person not
 informed correctly.

 So I propose following:

 1.You will demonstrate You PR code works ok on _official_ myth master.
 I'll be then co-work with You to move forward with Your code inclusion
 into master

 2.You will choose not doing 1\ and then I'll stop guessing what You are
 doing

 br

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13335#comment:17>
MythTV <http://www.mythtv.org>
MythTV Media Center