[mythtv-commits] Ticket #13323: Cleanup key press handling in MythMusic
MythTV
noreply at mythtv.org
Wed Nov 7 11:51:34 UTC 2018
#13323: Cleanup key press handling in MythMusic
----------------------------------+-------------------------------
Reporter: David Hampton | Owner: David Hampton
Type: Bug Report - General | Status: closed
Priority: minor | Milestone: 30.0
Component: Plugin - MythMusic | Version: Master Head
Severity: medium | Resolution: fixed
Keywords: | Ticket locked: 0
----------------------------------+-------------------------------
Changes (by David Hampton <mythtv@…>):
* resolution: Fixed => fixed
Comment:
In [changeset:"a2cb1e42fbc1979d7a995a2d9a4862a66fc73cea/mythtv"
a2cb1e42fb/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="a2cb1e42fbc1979d7a995a2d9a4862a66fc73cea"
MusicCommon::keyPressEvent should call its parent.
This cleans up the code, since each of its callers doesn't have to
explicitly call both its parent (this function) and its grandparent.
This issue was pointed out by the clang-tidy
bugprone-parent-virtual-call check.
Fixes #13323
}}}
--
Ticket URL: <https://code.mythtv.org/trac/ticket/13323#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list