[mythtv-commits] Ticket #13233: Android Hardware accelerated decode

[MythTV]

#13233: Android Hardware accelerated decode
-----------------------------+-------------------------------
 Reporter:  Peter Bennett    |          Owner:  Peter Bennett
     Type:  Developer Task   |         Status:  assigned
 Priority:  minor            |      Milestone:  unknown
Component:  Ports - Android  |        Version:  Master Head
 Severity:  medium           |     Resolution:
 Keywords:                   |  Ticket locked:  0
-----------------------------+-------------------------------

Comment (by Peter Bennett <pbennett@…>):

 In [changeset:"88eb4ef872c9e8cd17bf81174b1d4e92de23641e/mythtv"
 88eb4ef87/mythtv]:
 {{{
 #!CommitTicketReference repository="mythtv"
 revision="88eb4ef872c9e8cd17bf81174b1d4e92de23641e"
 FFmpeg avcodec: Fix segmentation fault with decoding on android oreo

 avcodec_receive_frame consistently causes a seg fault when decoding 1080i
 mpeg2
 on android version oreo. When copying the frame, the second plane in the
 buffer
 follows on immediately after 1080 lines of the first plane, but the code
 assumes
 it is after 1088 lines of the first plane, based on slice_height. It
 crashes on
 copying data for the second plane when it hits the actual end of the data
 and
 starts accessing addresses beyond that.

 Instead of using slice_height here, change to use use height. slice_height
 is
 used at other places in this module and I do not know if they also need to
 be
 changed. I have confirmed that with this change, decoding works correctly
 on android oreo as well as on the prior version, android nougat.

 Refs #13233
 }}}

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13233#comment:18>
MythTV <http://www.mythtv.org>
MythTV Media Center