[mythtv-commits] mythtv branch master updated by dhampton. v30-Pre-578-gafa5f98
Git Repo Owner
noreply at mythtv.org
Mon Apr 9 23:51:25 UTC 2018
The branch, master has been updated on the
mythtv repository by gitolite user dhampton.
via afa5f98391f8d64863a70544d4f93f9d6047664b (commit)
via 62aa13f47754585229e40db9c67026df46773ee4 (commit)
via c40c35079d6fecbd0048e9d616ca0eff3bd6df2c (commit)
via 6b5733edea7f6ddcbbfcffa06cfdf7b04ed2511e (commit)
via 5f464450f33b9c2a1b1a20f1a40385e18b98811c (commit)
via 847b01a2cb98632b5f6cc82c179688eb582bbe2b (commit)
via bd46ffcb5374a8f1e2f68e6e5bfc348c654f9bd8 (commit)
via d2e0486a9cf4a3999a7ea8b724a80ebd03b70106 (commit)
via 61ce3ff0437c557408cfd260c691fedacc587db2 (commit)
via 81f4dd3302635d6bc3b1df96a874c17ddde606e3 (commit)
via 6d6fd71554ebdb80c985ac8cc5f8e8d048802c29 (commit)
via d72a545dde1927a1743a0abb42f8c6c00976c3b4 (commit)
via 825f9f50cbf94c5d03ebf5f5e1a002f34d5f2956 (commit)
via fc3e361b6c69bfff13a292a38ae1094685da14ad (commit)
via 635b54a723b4137b9d2a8cc2a8fa5ee1f336d41a (commit)
via 71ea5a0b44029d238794400058519fad95fe696d (commit)
via 0a60bb9e6ab481b6b5d5ac9aef080a2dcdfbd7bf (commit)
via a1ecfaa04b8d3d0d44da2df84a1431ae524a3548 (commit)
via 5563be29510e0adb0137a04055b020df3b14990e (commit)
via e25487a635db0e4c5f0ca8181d14a965a8262698 (commit)
via 20d39d758275d9d0e174003ef81ade3bd84a6d53 (commit)
via 9e2ee0b79387f815547b40736bbad9941a717322 (commit)
from 067c37849fd536c8d98d73a281b5467946b043df (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit afa5f98391f8d64863a70544d4f93f9d6047664b
Author: David Hampton <mythtv at love2code.net> at Mon, 9 Apr 2018 18:11:45 -0400
Committer: David Hampton <mythtv at love2code.net> at Mon, 9 Apr 2018 18:11:45 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=afa5f98391f8d64863a70544d4f93f9d6047664b
Fix GCC8 warning about a 'case value not in enumerated type'.
The code is using "QEvent::User" and "QEvent::User + 1" to denote two
different events. This is part of the number space allocated by Qt
for user defined events, but only the first actually appears in the Qt
enum. The latter, and any other user defined events used with the
QEvent::Type type, will cause compiler warnings. Solve this by
disabling the GCC "-Wswitch" warning for this one and only instance of
the problem.
commit 62aa13f47754585229e40db9c67026df46773ee4
Author: David Hampton <mythtv at love2code.net> at Mon, 9 Apr 2018 18:09:56 -0400
Committer: David Hampton <mythtv at love2code.net> at Mon, 9 Apr 2018 18:09:56 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=62aa13f47754585229e40db9c67026df46773ee4
Fix Clang6 'deprecated-register' warnings in mythmusic.
Clang warns that the 'register' storage class specifier is deprecated
and incompatible with C++17. Remove a number of instances of this
keyword.
commit c40c35079d6fecbd0048e9d616ca0eff3bd6df2c
Author: David Hampton <mythtv at love2code.net> at Mon, 9 Apr 2018 18:05:17 -0400
Committer: David Hampton <mythtv at love2code.net> at Mon, 9 Apr 2018 18:05:17 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=c40c35079d6fecbd0048e9d616ca0eff3bd6df2c
Fix clang6 warnings about non-final object / non-virtual destructor.
The full warning is: "delete called on non-final 'FileSystemInfo' that
has virtual functions but non-virtual destructor". Marking the
destructor as virtual eliminates this warning.
commit 6b5733edea7f6ddcbbfcffa06cfdf7b04ed2511e
Author: David Hampton <mythtv at love2code.net> at Mon, 9 Apr 2018 18:02:30 -0400
Committer: David Hampton <mythtv at love2code.net> at Mon, 9 Apr 2018 18:02:30 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=6b5733edea7f6ddcbbfcffa06cfdf7b04ed2511e
Fix clang6 warning about an unused variable.
The code has an iterator that isn't used, so remove it.
commit 5f464450f33b9c2a1b1a20f1a40385e18b98811c
Author: David Hampton <mythtv at love2code.net> at Mon, 9 Apr 2018 08:49:33 -0400
Committer: David Hampton <mythtv at love2code.net> at Mon, 9 Apr 2018 08:49:33 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=5f464450f33b9c2a1b1a20f1a40385e18b98811c
Remove the clang "-Wno-self-assign" compiler flag.
Also cleans up the one location in the code that does self assign.
This is an operator= function for copying an object, and the existing
comment says it is intentionally keeping the old values. Commenting
out the self-assignment (instead of removing it) eliminates the error,
but also highlights which fields are kept from the old object.
commit 847b01a2cb98632b5f6cc82c179688eb582bbe2b
Author: David Hampton <mythtv at love2code.net> at Sun, 8 Apr 2018 22:50:05 -0400
Committer: David Hampton <mythtv at love2code.net> at Sun, 8 Apr 2018 23:24:12 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=847b01a2cb98632b5f6cc82c179688eb582bbe2b
Clean up gcc compiler warning flags.
Remove a duplicate "-Werror=format-security" clause. Remove the
"-Wformat" flag which is already enabled by the "-Wall" flag. All of
the switch clauses that fall through have been correctly marked, so
there are no longer any warning messages to be silenced by the
"-Wno-switch" flag.
commit bd46ffcb5374a8f1e2f68e6e5bfc348c654f9bd8
Author: David Hampton <mythtv at love2code.net> at Tue, 27 Feb 2018 22:13:03 -0500
Committer: David Hampton <mythtv at love2code.net> at Sun, 8 Apr 2018 22:36:20 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=bd46ffcb5374a8f1e2f68e6e5bfc348c654f9bd8
Rewrite call that used QCoreApplication::hasPendingEvents.
This function was deprecated in Qt5.3. Use a signal/slot pair to
replace the call to postEvent() and polling with hasPendingEvents().
commit d2e0486a9cf4a3999a7ea8b724a80ebd03b70106
Author: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 18:24:02 -0400
Committer: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 18:24:02 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=d2e0486a9cf4a3999a7ea8b724a80ebd03b70106
Add comment about a 'deprecated declaration'.
It appears that glibc had deprecated AutoPtr, and the exiv2 library
hasn't been updated with a replacement.
commit 61ce3ff0437c557408cfd260c691fedacc587db2
Author: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 18:13:06 -0400
Committer: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 18:18:52 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=61ce3ff0437c557408cfd260c691fedacc587db2
Fix Clang6 about mheg using two different enums in a switch statement.
The MHEG code defines two different enums with essentially the same
names and values. In the CallProgram function, in a single switch
statement it uses one value from one enum, and the remaining values
from the other enum. Convert the function to be consistent and only
use the values from a single enum. The .o files from before/after
this change were compared and there was no difference in the compiled
code.
commit 81f4dd3302635d6bc3b1df96a874c17ddde606e3
Author: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 18:11:31 -0400
Committer: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 18:19:05 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=81f4dd3302635d6bc3b1df96a874c17ddde606e3
Fix Clang6 unused iterator variable warning in mythcommflag.
commit 6d6fd71554ebdb80c985ac8cc5f8e8d048802c29
Author: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 18:07:47 -0400
Committer: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 18:18:52 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=6d6fd71554ebdb80c985ac8cc5f8e8d048802c29
Fix Clang6 'deprecated-register' warnings in visualizer.
Clang warns that the 'register' storage class specifier is deprecated
and incompatible with C++17. Remove a number of instances of this
keyword.
commit d72a545dde1927a1743a0abb42f8c6c00976c3b4
Author: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 17:58:00 -0400
Committer: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 17:58:00 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=d72a545dde1927a1743a0abb42f8c6c00976c3b4
Fix GCC8 warning about cases falling through.
There is no possibility of fallthrough, as the switch() is being
performed on an enum and all values of the enum have been accounted
before. It seems like the problem is that the variable is of type int
instead of enum, but adding a static cast doesn't eliminate the
warning messages. Add explicit break statements to make the compiler
happy, even though they serve no other purpose.
commit 825f9f50cbf94c5d03ebf5f5e1a002f34d5f2956
Author: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 08:40:39 -0400
Committer: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 08:40:39 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=825f9f50cbf94c5d03ebf5f5e1a002f34d5f2956
Fix GCC8 complaint about unnecessary parentheses.
Remove an unnecessary set of parentheses to eliminate the warning.
commit fc3e361b6c69bfff13a292a38ae1094685da14ad
Author: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 08:33:53 -0400
Committer: David Hampton <mythtv at love2code.net> at Fri, 6 Apr 2018 08:33:53 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=fc3e361b6c69bfff13a292a38ae1094685da14ad
Fix GCC8 warning about 'clearing an object of non-trivial type'.
According to the FFTW documentation at
http://www.fftw.org/fftw3_doc/Real_002ddata-DFTs.html, the input and
output arrays will all be overwritten during planning and do not need
to be initialized. Removing the unnecessary initialization by MythTV
eliminates the warning messages.
commit 635b54a723b4137b9d2a8cc2a8fa5ee1f336d41a
Author: David Hampton <mythtv at love2code.net> at Thu, 5 Apr 2018 19:55:45 -0400
Committer: David Hampton <mythtv at love2code.net> at Thu, 5 Apr 2018 19:55:45 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=635b54a723b4137b9d2a8cc2a8fa5ee1f336d41a
Eliminate warnings about '[[clang::fallthrough]]'.
Versions of GCC before version 7 complain that the "clang::" part of
this construct isn't valid. Turn off the compile -Wattributes flag
only for those compiles to get rid of the warning messages. The
compiler flag remains on for all other releases.
commit 71ea5a0b44029d238794400058519fad95fe696d
Author: David Hampton <mythtv at love2code.net> at Tue, 27 Mar 2018 22:40:53 -0400
Committer: David Hampton <mythtv at love2code.net> at Wed, 28 Mar 2018 00:29:46 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=71ea5a0b44029d238794400058519fad95fe696d
Replace auto_ptr with unique_ptr in cdrip.cpp.
The C++11 standard deprecated the auto_ptr class template, and it has
been completely removed from the C++17 standard. The replacement
template is the unique_ptr template.
commit 0a60bb9e6ab481b6b5d5ac9aef080a2dcdfbd7bf
Author: David Hampton <mythtv at love2code.net> at Tue, 27 Mar 2018 22:38:44 -0400
Committer: David Hampton <mythtv at love2code.net> at Wed, 28 Mar 2018 00:29:46 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=0a60bb9e6ab481b6b5d5ac9aef080a2dcdfbd7bf
Clang: Fix "enumeration values not handled in switch" warning in mythmainwindow.cpp.
Add a 'default' case to the keyLongPressFilter function so clang
doesn't complain about the missing 168 cases.
commit a1ecfaa04b8d3d0d44da2df84a1431ae524a3548
Author: David Hampton <mythtv at love2code.net> at Tue, 27 Mar 2018 22:31:09 -0400
Committer: David Hampton <mythtv at love2code.net> at Wed, 28 Mar 2018 00:29:46 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=a1ecfaa04b8d3d0d44da2df84a1431ae524a3548
Clang: Fix "private field is not used" warnings in audiooutputbase.h.
These fields are used inside of an assert statement, so they are only
referenced when the NDEBUG flag isn't passed into the compilation. If
the NDEBUG flag is provided, these fields are truly unused. Add the
Q_UNUSED macro to quiet the warnings for these compiles.
commit 5563be29510e0adb0137a04055b020df3b14990e
Author: David Hampton <mythtv at love2code.net> at Tue, 27 Mar 2018 22:19:00 -0400
Committer: David Hampton <mythtv at love2code.net> at Wed, 28 Mar 2018 00:29:46 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=5563be29510e0adb0137a04055b020df3b14990e
Clang: Eliminate illegal character encoding warnings in vbilut.c.
Clang complains about characters in strings that use "high-ascii"
values, because these aren't valid in a source file using the utf-8
encoding. Change these characters to hex values to eliminate the
warnings. Compare the object files produced from the clang compiler
from before and after this change was compared to make sure they are
identical.
commit e25487a635db0e4c5f0ca8181d14a965a8262698
Author: David Hampton <mythtv at love2code.net> at Tue, 27 Mar 2018 22:09:39 -0400
Committer: David Hampton <mythtv at love2code.net> at Wed, 28 Mar 2018 00:29:46 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=e25487a635db0e4c5f0ca8181d14a965a8262698
Clang: Change a variable from 'char' to 'unsigned char' in vbilut.cpp.
This is a preparatory commit for the next commit. This change from
signed to unsigned only causes changes in the debug sections of the
resulting ELF file.
commit 20d39d758275d9d0e174003ef81ade3bd84a6d53
Author: David Hampton <mythtv at love2code.net> at Mon, 26 Mar 2018 01:19:15 -0400
Committer: David Hampton <mythtv at love2code.net> at Wed, 28 Mar 2018 00:29:46 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=20d39d758275d9d0e174003ef81ade3bd84a6d53
Clang: Eliminate an inconsistent override warning in vsync.h.
The clang warning message is: "overrides a member function but is not
marked 'override'". Fix these by adding the override keyword on the
specified functions.
commit 9e2ee0b79387f815547b40736bbad9941a717322
Author: David Hampton <mythtv at love2code.net> at Mon, 26 Mar 2018 01:03:18 -0400
Committer: David Hampton <mythtv at love2code.net> at Mon, 26 Mar 2018 01:21:41 -0400
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=9e2ee0b79387f815547b40736bbad9941a717322
Eliminate an unused parameter warning in ffmpeg.
The code path that uses this variable is conditionally compiled, so
the case where is is not compiled needs a void reference to quiet the
compiler.
-----------------------------------------------------------------------
Summary of changes:
mythplugins/mythmusic/mythmusic/cdrip.cpp | 2 +-
mythplugins/mythmusic/mythmusic/inlines.h | 50 ++++++++++----------
mythplugins/mythmusic/mythmusic/visualize.cpp | 9 +---
mythtv/configure | 11 ++--
mythtv/external/FFmpeg/libavcodec/mpegvideo.h | 4 +-
mythtv/external/FFmpeg/libavformat/os_support.h | 2 +
mythtv/libs/libmyth/audio/audiooutputbase.cpp | 7 +++
mythtv/libs/libmythbase/filesysteminfo.h | 2 +-
mythtv/libs/libmythbase/mythevent.cpp | 4 --
mythtv/libs/libmythbase/mythevent.h | 2 -
mythtv/libs/libmythfreemheg/Programs.cpp | 10 ++--
mythtv/libs/libmythmetadata/imagemetadata.cpp | 11 ++++
mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp | 4 +-
.../libs/libmythtv/channelscan/channelscan_sm.cpp | 2 -
mythtv/libs/libmythtv/netstream.cpp | 3 +
mythtv/libs/libmythtv/vbilut.cpp | 38 +++++++-------
mythtv/libs/libmythtv/vbilut.h | 4 +-
.../libmythtv/visualisations/videovisualdefs.h | 30 ++++++------
mythtv/libs/libmythtv/vsync.h | 22 ++++----
mythtv/libs/libmythui/mythmainwindow.cpp | 29 ++---------
mythtv/libs/libmythui/mythmainwindow.h | 4 +-
mythtv/programs/mythcommflag/main.cpp | 1 -
22 files changed, 121 insertions(+), 130 deletions(-)
--
More information about the mythtv-commits
mailing list