[mythtv-commits] Ticket #13114: Import Recorder Fix

MythTV noreply at mythtv.org
Mon Oct 16 14:05:25 UTC 2017

#13114: Import Recorder Fix
 Reporter:  devmonkey@…         |          Owner:  pbennett
     Type:  Patch - Bug Fix     |         Status:  infoneeded
 Priority:  minor               |      Milestone:  30.0
Component:  MythTV - Recording  |        Version:  0.28.1
 Severity:  medium              |     Resolution:
 Keywords:                      |  Ticket locked:  0

Comment (by devmonkey@…):

 I gather the original idea of the recorder was to create links based on
 the filename you supply purely for the purpose of testing. I believe the
 suggestion in the wiki and setup program is to leave the filename blank
 and use system events to write directly to the recording file if you wish
 to genuinely import something (this is how I use it). Supplying a fixed
 filename to import only makes sense in the context of testing as I don't
 see that being particularly workable otherwise. If the import file in the
 settings does not exist this will suppress the link generation. So I
 believe that already supplies a valid method to toggle between testing
 (link creation) and normal operation (direct write via system event). I
 believe the demo recorder would be the one to use to make a real-time copy
 of a file. Presumably the import recorder was created for space / time
 saving to help test the other functionality of MythTV. I think leaving the
 link creation in is ok unless we're sure no one does any testing like that
 any more.

 I moved the log message to VB_COMMFLAG, VB_INFO. For my 10 p I would only
 ever want to see those messages for debugging in the context of other
 messages when the process was freezing at some point.

 virtual has been removed from header that shouldn't have been in there as
 it was just for readability for me. I believe the override keyword is now
 preferred anyway.

 I did note the black box recorder was there but I haven't tested it. It
 looks like it would have been more work to essentially do the same thing.
 Also I'm not sure whether I could make it import anything outside the
 scheduled recording time so probably another issue to solve that doesn't
 exist right now. With regards the hdpvr2 app I did do some testing with
 pipes and named pipes and this was prone to problems with buffer overruns
 so again more issues to fix that don't exist with a direct file write.

 If you were willing to go to the extra cost you could make it work with 2
 STBs and 2 recorder devices. Unless I was serving up content for a lot of
 people I'm not sure I'd need dual import though as sequential import of
 dual recordings is more cost effective and already working + you could
 turn that into dual sequential if you really did need that kind of extra
 capacity. I also suspect the hdpvr2 app would need fixing again to work
 with 2 recorder devices.

 Anyway hopefully that is enough to get this merged as it's currently a
 broken feature so low risk from the point of regressions. It's also
 potentially a flexible extension for supporting any new devices where it
 might not be practical to offer direct support in MythTV.

Ticket URL: <https://code.mythtv.org/trac/ticket/13114#comment:9>
MythTV <http://www.mythtv.org>
MythTV Media Center

More information about the mythtv-commits mailing list