[mythtv-commits] mythtv branch master updated by dhampton. v30-Pre-278-g752a007

Git Repo Owner noreply at mythtv.org
Thu Nov 2 00:55:29 UTC 2017


The branch, master has been updated on the
mythtv repository by gitolite user dhampton.
       via  752a0070cbeed18eccb322c1c103eb51370bc665 (commit)
       via  030ecdecc5603ba8e583a5ea04e7205efd314175 (commit)
       via  527fca95c3d4c6c98a2041d9cec5e0d023ecf400 (commit)
       via  5a6dd1625cb0cf8ca18a6446a333b3615c8a2274 (commit)
      from  72946446b7d14d74c13c2fc66110daaa4062cada (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 752a0070cbeed18eccb322c1c103eb51370bc665
Author:    David Hampton <mythtv at love2code.net> at Sun, 9 Jul 2017 12:06:01 -0400
Committer: David Hampton <mythtv at love2code.net> at Wed, 1 Nov 2017 20:44:16 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=752a0070cbeed18eccb322c1c103eb51370bc665

Eliminate MythCookieJar copy constructor.
MythCookieJar fix attempt #3.

The MythCookieJar object is based on QObject and therefore shouldn't
have a public copy constructor. Unfortunately its two main purposes
are to load/save cookies from/to a file, and to copy cookies between
multiple cookie jars.  This fix simply splits the copy constructor
into its two components; creating a new jar and copying cookies from
one jar to another.  It is probably not the ideal solution, but it has
the smallest impact on the existing code base.

General: Instances of QObject (and its subclasses) should be
considered unique items that cannot be copied.  Knowing that each
object has only one parent and an arbitrary number of children makes
it easier to understand this. Even if you "clone" the object by
setting all the member variables to the same values, you can't set the
parent and child variables to the same values without screwing up the
one-to-many relationship of parent to children.

See:
http://doc.qt.io/qt-5/qobject.html#Q_DISABLE_COPY
https://www.ics.com/designpatterns/book/qobject.html

Refs #13069



commit 030ecdecc5603ba8e583a5ea04e7205efd314175
Author:    David Hampton <mythtv at love2code.net> at Fri, 2 Jun 2017 18:09:10 -0400
Committer: David Hampton <mythtv at love2code.net> at Wed, 1 Nov 2017 20:44:16 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=030ecdecc5603ba8e583a5ea04e7205efd314175

Remove public copy constructors from MythSystemLegacy.
The MythSystemLegacy object is based on QObject and therefore
shouldn't have a public copy constructor. Update the code to
properly initialize the parent QObject, and to remove the
unused copy constructor.

General: Instances of QObject (and its subclasses) should be
considered unique items that cannot be copied.  Knowing that each
object has only one parent and an arbitrary number of children makes
it easier to understand this. Even if you "clone" the object by
setting all the member variables to the same values, you can't set the
parent and child variables to the same values without screwing up the
one-to-many relationship of parent to children.

See:
http://doc.qt.io/qt-5/qobject.html#Q_DISABLE_COPY
https://www.ics.com/designpatterns/book/qobject.html

Refs #13069



commit 527fca95c3d4c6c98a2041d9cec5e0d023ecf400
Author:    David Hampton <mythtv at love2code.net> at Thu, 8 Jun 2017 23:34:39 -0400
Committer: David Hampton <mythtv at love2code.net> at Wed, 1 Nov 2017 20:44:16 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=527fca95c3d4c6c98a2041d9cec5e0d023ecf400

FileSystemInfo and MetaGrabberScript don't need to be based on QObject.
These classes don't use any of the features of QObject, so removing its
dependency on QObject is the simplest chage to eliminate the warning
message:

   warning: base class ‘class QObject’ should be explicitly
   initialized in the copy constructor [-Wextra]

Refs #13069



commit 5a6dd1625cb0cf8ca18a6446a333b3615c8a2274
Author:    David Hampton <mythtv at love2code.net> at Thu, 20 Apr 2017 00:48:22 -0400
Committer: David Hampton <mythtv at love2code.net> at Wed, 1 Nov 2017 20:44:16 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=5a6dd1625cb0cf8ca18a6446a333b3615c8a2274

Update EncoderLink::StartRecording return type comment.
This function returns a RecStatus::Type, not a -1 for bad,
0 for unknown, or 1 for good.



-----------------------------------------------------------------------

Summary of changes:
 mythtv/libs/libmythbase/filesysteminfo.h        |    3 +-
 mythtv/libs/libmythbase/mythdownloadmanager.cpp |   15 ++++++----
 mythtv/libs/libmythbase/mythsystemlegacy.cpp    |   31 ++++++----------------
 mythtv/libs/libmythbase/mythsystemlegacy.h      |   11 +++----
 mythtv/libs/libmythmetadata/metadatagrabber.h   |    2 +-
 mythtv/programs/mythbackend/encoderlink.cpp     |    3 +-
 6 files changed, 26 insertions(+), 39 deletions(-)

-- 



More information about the mythtv-commits mailing list