[mythtv-commits] Ticket #13001: [patch] fix WebFrontend user agent detection on Apple systems

[MythTV]

#13001: [patch] fix WebFrontend user agent detection on Apple systems
-------------------------------------------------+-------------------------
 Reporter:  ctreleaven@…                         |          Owner:  stuartm
     Type:  Patch - Bug Fix                      |         Status:  new
 Priority:  minor                                |      Milestone:  0.28.2
Component:  MythTV - Web Frontend                |        Version:  0.28.1
 Severity:  medium                               |     Resolution:
 Keywords:  user agent detection Apple           |  Ticket locked:  0
  Macintosh                                      |
-------------------------------------------------+-------------------------

Comment (by stuartm):

 At the time this was written I didn't have a Mac to test with, I now do
 although at the current moment I'm separated from it by a few thousand
 miles.

 The patch looks fine.
 I
 For the 'Download' issue, we should be setting the 'Content-Disposition'
 header, which on most browsers is interpreted as 'download' instead of
 'handle' the content. I thought I had done this, with it specifying a
 user-friendly filename at the same time but this doesn't appear to be the
 case in the current master meaning I must have forgotten to commit it a
 couple of years back. Whoops.

 After all this time, I've no idea if I'll be able to find the original
 patch in git stash or a branch, it might be faster to do it again from
 scratch. Fortunately, I have a little free time in the evenings at the
 moment so I'll look at adding this.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13001#comment:5>
MythTV <http://www.mythtv.org>
MythTV Media Center