[mythtv-commits] Ticket #13109: Feature patch - Fix FIXME in libhdhomerun.pro

[MythTV]

#13109: Feature patch - Fix FIXME in libhdhomerun.pro
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:
  <gary.buhrmaster@…>                            |
         Type:  Patch - Feature                  |     Status:  new
     Priority:  minor                            |  Milestone:
                                                 |  needs_triage
    Component:  MythTV - General                 |    Version:  Master Head
     Severity:  medium                           |   Keywords:
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 Feature patch - Fix FIXME in libhdhomerun.pro

 Commit 5ed7db9 modified the mythtv specific libhdhomerun.pro file to work
 around an issue with QMAKE_STRIP being empty by commenting out the strip.

 Re-enable the strip when possible by adding in a test (!isEmpty) to the
 scope.

 Lightly tested.

 Proposed Patch follows:

 {{{
 diff --git a/mythtv/external/libhdhomerun/libhdhomerun.pro
 b/mythtv/external/libhdhomerun/libhdhomerun.pro
 index c0251bbf48..6a33dfb815 100644
 --- a/mythtv/external/libhdhomerun/libhdhomerun.pro
 +++ b/mythtv/external/libhdhomerun/libhdhomerun.pro
 @@ -89,8 +89,7 @@ Makefile.app {

      QMAKE_CLEAN += $(TARGET)

 -    # FIXME QMAKE_STRIP is empty sometimes, skip for now
 -    # unix:QMAKE_POST_LINK=$${QMAKE_STRIP} $(TARGET)
 +    unix: !isEmpty(QMAKE_STRIP): QMAKE_POST_LINK=$${QMAKE_STRIP}
 $(TARGET)

      SOURCES += hdhomerun_config.c

 }}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13109>
MythTV <http://www.mythtv.org>
MythTV Media Center