[mythtv-commits] Ticket #13106: Mythtv Video Service API GetVideoByFileName memory leak

[MythTV]

#13106: Mythtv Video Service API GetVideoByFileName memory leak
---------------------------------------------+------------------------
 Reporter:  rich@…                           |          Owner:  bmeek
     Type:  Bug Report - Memory Leak         |         Status:  closed
 Priority:  minor                            |      Milestone:  0.28.2
Component:  MythTV - Services API - Backend  |        Version:  0.28.1
 Severity:  low                              |     Resolution:  fixed
 Keywords:                                   |  Ticket locked:  0
---------------------------------------------+------------------------

Comment (by natanojl):

 The fix itself looks alright, but I have to question the original author's
 use of heap allocation here.

 !VideoMetadataListManager only contains a pointer member and is only used
 temporarily so I think we should use the stack here.

 It is quite inconsistent, VideoMetadataListManager::metadata_list is three
 times larger than !VideoMetadataListManager it seems, but videolist is
 (correctly in my opinion) in allocated on the stack.

 It probably doesn't matter very much, it just caught my eye.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13106#comment:4>
MythTV <http://www.mythtv.org>
MythTV Media Center