[mythtv-commits] Ticket #13084: ttvdb.py will cease to function - TTVDB will discontinue support for V1 XML API in 3 months time on October 1st, 2017
MythTV
noreply at mythtv.org
Sat Aug 19 01:09:19 UTC 2017
#13084: ttvdb.py will cease to function - TTVDB will discontinue support for V1 XML
API in 3 months time on October 1st, 2017
-------------------------------------------------+-------------------------
Reporter: Frederick Henderson <frederickjh@…> | Owner:
| markspieth
Type: Bug Report - General | Status:
| assigned
Priority: minor | Milestone: 29.0
Component: MythTV - Mythmetadatalookup | Version:
| Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
-------------------------------------------------+-------------------------
Comment (by markspieth):
Review Responses:
1. This is not really a bug fix so was not treated as such. hence the
major version change to 2.0
2. The reason for the new dependencies is the upstream api now uses them.
The updated API was chosen to be the path of least resistance as the
interface is the same (almost). There was a case that the data returned
was not as good as the old api so some enhancements were made. These are
being pushed upstream to the parent repo.
3. I agree with the API key being in the module as bad but as you say this
is legacy and beyond the scope of this API update.
4. Python3 compatability can be split out from the pull request if
required as it is independent and in a separate changeset. Naturally my
preference is to not spend any extra effort if people are happy with the
current state of the update.
Now that it (seems to) works with the older versions of requests and
requests_cache, that should resolve any final issues.
--
Ticket URL: <https://code.mythtv.org/trac/ticket/13084#comment:34>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list