[mythtv-commits] Ticket #13054: Video Playback vertical offset when using UseVideoModes=1 for JudderFree support

[MythTV]

#13054: Video Playback vertical offset when using UseVideoModes=1 for JudderFree
support
-------------------------------------+--------------------------
 Reporter:  support@…                |          Owner:  pbennett
     Type:  Bug Report - General     |         Status:  new
 Priority:  minor                    |      Milestone:  unknown
Component:  MythTV - Video Playback  |        Version:  0.28.1
 Severity:  medium                   |     Resolution:
 Keywords:                           |  Ticket locked:  0
-------------------------------------+--------------------------

Comment (by Steven Ellis <support@…>):

 To assist with debugging I inserted some additional debug LOGs into the
 source
 {{{
 diff --git a/mythtv/libs/libmythtv/tv_play.cpp
 b/mythtv/libs/libmythtv/tv_play.cpp
 index 12fa839..22de436 100644
 --- a/mythtv/libs/libmythtv/tv_play.cpp
 +++ b/mythtv/libs/libmythtv/tv_play.cpp
 @@ -2606,6 +2606,7 @@ void TV::HandleStateChange(PlayerContext *mctx,
 PlayerContext *ctx)
          // skip this logic in that case.
          if (!switchMode)
          {
 +            LOG(VB_PLAYBACK, LOG_INFO, LOC + "UseVideoModes is 0");
              MythMainWindow *mainWindow = GetMythMainWindow();
              mainWindow->setBaseSize(player_bounds.size());
              mainWindow->setMinimumSize(
 @@ -9880,6 +9881,7 @@ void TV::customEvent(QEvent *e)
          if (!switchMode
              && (!db_use_gui_size_for_tv || !db_use_fixed_size))
          {
 +            LOG(VB_PLAYBACK, LOG_INFO, LOC + "UseVideoModes is 0");
              mwnd->setMinimumSize(QSize(16, 16));
              mwnd->setMaximumSize(QSize(QWIDGETSIZE_MAX,
 QWIDGETSIZE_MAX));
              mwnd->setGeometry(player_bounds.left(), player_bounds.top(),

 diff --git a/mythtv/libs/libmythtv/videoout_opengl.cpp
 b/mythtv/libs/libmythtv/videoout_opengl.cpp
 index a743e92..2bbb2f0 100644
 --- a/mythtv/libs/libmythtv/videoout_opengl.cpp
 +++ b/mythtv/libs/libmythtv/videoout_opengl.cpp
 @@ -363,6 +363,8 @@ bool VideoOutputOpenGL::SetupOpenGL(void)
      if (!gl_context)
          return false;

 +
 +    LOG(VB_PLAYBACK, LOG_INFO, LOC + "SetupOpenGL");
      QRect dvr = window.GetDisplayVisibleRect();

      MythMainWindow *mainWin = GetMythMainWindow();


 diff --git a/mythtv/libs/libmythtv/videooutwindow.cpp
 b/mythtv/libs/libmythtv/videooutwindow.cpp
 index 0ea9a17..ac56d04 100644
 --- a/mythtv/libs/libmythtv/videooutwindow.cpp
 +++ b/mythtv/libs/libmythtv/videooutwindow.cpp
 @@ -100,6 +100,7 @@ void VideoOutWindow::populateGeometry(void)
  {
      qApp->processEvents();
      QDesktopWidget *desktop = NULL;
 +    LOG(VB_PLAYBACK, LOG_INFO, "populateGeometry");
      if (qobject_cast<QApplication*>(qApp))
          desktop = QApplication::desktop();
 }}}

 Output confirmed that the correct paths were being taken for all playback
 modes when !UseVideoModes=1

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13054#comment:13>
MythTV <http://www.mythtv.org>
MythTV Media Center