[mythtv-commits] Ticket #13006: filenames turned into QUrls should be proper file: URLs

[MythTV]

#13006: filenames turned into QUrls should be proper file: URLs
----------------------------------+-------------------------
 Reporter:  brian@…               |          Owner:
     Type:  Bug Report - General  |         Status:  closed
 Priority:  minor                 |      Milestone:  unknown
Component:  MythTV - General      |        Version:  0.28.1
 Severity:  medium                |     Resolution:  Invalid
 Keywords:                        |  Ticket locked:  0
----------------------------------+-------------------------

Comment (by rsiddons):

 Because it's the wrong fix. It alters the interface for file transfers
 that may cause problems for others in the future.

 Myth has too many ugly tweaks already. This is one area that is well-
 defined, so we should preserve that.

 Your issue isn't the colon; it's that the file isn't being specified as a
 local file. Assuming it is a local file may work for you. Many of us keep
 private patches for our own. But we only commit patches that benefit
 everyone and don't break things.

 Consider:

 {{{
 #include <QUrl>
 #include <QDebug>
 int main() {
         qDebug() << QUrl("This:").path();        // ""
         qDebug() << QUrl("/This:").path();       // "/This:"
         qDebug() << QUrl("This").path();         // "This"
 }
 }}}
 Although the error message uses toString() the relevant code extracts the
 path().

 The internal interface is defined at
 https://www.mythtv.org/wiki/ANN_(Myth_Protocol)

 Note that the prefix "/" denotes it's a local file and Myth handles it
 correctly.

 I suggest you reopen the issue with Kodi PVR.

 The filename returned by the services API ("This:") won't have a prefix
 because the services don't require it. However Kodi PVR is then using the
 internal Myth protocol for playback, which does.
 They should be adding a prefix "/".

 You are the first to notice their bug because you are probably the first
 Kodi PVR user to use colons in filenames.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13006#comment:13>
MythTV <http://www.mythtv.org>
MythTV Media Center