[mythtv-commits] Ticket #13021: Feature patch: Entry to watching livetv from frontend EPG using select action

[MythTV]

#13021: Feature patch: Entry to watching livetv from frontend EPG using select
action
------------------------------+-----------------------------
 Reporter:  perkins1724@…     |          Owner:  pbennett
     Type:  Patch - Feature   |         Status:  assigned
 Priority:  minor             |      Milestone:  unknown
Component:  MythTV - General  |        Version:  Unspecified
 Severity:  low               |     Resolution:
 Keywords:                    |  Ticket locked:  0
------------------------------+-----------------------------

Comment (by pbennett):

 Regarding the above patch -
 * I cannot see what the checking of end time achieves. If the start time
 is less than the threshold or is in the past, the first condition is
 satisfied and none of the others is used. If the start time is greater
 than that threshold, the end time will be greater by even more,
 secsTillStart will be positive, so neither of the other conditions will be
 satisfied.
 * The test for if (!m_player) - It looks like you found a bug - In the
 current code if I watch a recording, then in the recording, select the
 guide and from there go to menu, watch this channel, there is an error
 message in the log and nothing happens. A check for !m-player would solve
 that, so this is a good find.

 My preferred solution:

 When running the guide not from inside LiveTV, you press enter in the
 guide, you get a menu with "Record this showing", "Record all showings"
 and 3 more items. This menu is different if there is a recording already
 set, a recording in progress, recording failed, etc. Add to the top of
 this menu "Watch This channel", in cases where you have selected the
 current playing show, or a show that starts within the specified time
 period.

 I would also like to add a feature that lets you set
 !SelChangeRecThreshold to -1 (or 0) and that would cause it to always go
 immediately to live tv if you select a show that is currently running, and
 go to the recording menu (with the watch livetv option included)
 otherwise. This is my preferred setting. If you do want to record a show
 that has already started, going to watch live tv and then pressing Record
 (R) is probably the fastest way of doing it anyway.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13021#comment:5>
MythTV <http://www.mythtv.org>
MythTV Media Center