[mythtv-commits] Ticket #12892: Gallery View jumps around when navigating bottom ~ 2 rows of videos

[MythTV]

#12892: Gallery View jumps around when navigating bottom ~ 2 rows of videos
---------------------------------------------+-----------------------------
 Reporter:  kc8vfa@…                         |          Owner:  pbennett
     Type:  Bug Report - General             |         Status:  assigned
 Priority:  minor                            |      Milestone:  unknown
Component:  MythTV - User Interface Library  |        Version:  Unspecified
 Severity:  medium                           |     Resolution:
 Keywords:  Gallery View,  navigation        |  Ticket locked:  0
---------------------------------------------+-----------------------------
Changes (by pbennett):

 * owner:  jpoet => pbennett


Comment:

 John Poet said:

 In my opinion, reverting those commits does not make any sense.  Those
 commits fix a much more common problem which affects the main 'Watch
 Recordings' screen. This issue only affects users using a grid-view, which
 they have the option of not using.

 If this issue is more important to you, the following will "fix" it at the
 expense of  https://code.mythtv.org/trac/ticket/8441 :
 {{{
 diff --git a/mythtv/libs/libmythui/mythuibuttonlist.cpp
 b/mythtv/libs/libmythui/
 index 9c25ff4..988b1b6 100644
 --- a/mythtv/libs/libmythui/mythuibuttonlist.cpp
 +++ b/mythtv/libs/libmythui/mythuibuttonlist.cpp
 @@ -1335,13 +1335,15 @@ void
 MythUIButtonList::CalculateButtonPositions(void)
                                      m_columns * m_columns;
              }

 -
 +#if 0
 +            // Adjusted if last item is deleted
              if (((m_itemList.count() - m_topPosition)
                   < static_cast<int>(m_itemsVisible)) &&
                  (m_selPosition - (static_cast<int>(m_itemsVisible) - 1)
                   < m_topPosition))
                  m_topPosition = m_selPosition -
                                  (static_cast<int>(m_itemsVisible) - 1);
 +#endif

              m_topPosition = qMax(m_topPosition, 0);
              break;
 }}}

 To fix this issue without re-breaking #8441, that block of code needs
 updated to take into account the grid layout option.  It has been long
 enough since I worked on this code, that I will have to re-familiarize
 myself with it, so I can figure out the correct solution.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12892#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center