[mythtv-commits] Ticket #12914: Patch: handle duplicate xmltv ratings

[MythTV]

#12914: Patch: handle duplicate xmltv ratings
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:  stuartm
  <gary.buhrmaster@…>                            |
         Type:  Patch - Bug Fix                  |     Status:  new
     Priority:  trivial                          |  Milestone:  unknown
    Component:  MythTV - Mythfilldatabase        |    Version:  Master Head
     Severity:  low                              |   Keywords:
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 While it may not be a reasonable implementation, the xmltv definition does
 not preclude their being duplicate (and useless) program ratings, and
 there have been reports of certain upstreams occasionally providing
 duplicates.  This results in errors from mythfilldatabase for a legitimate
 (although questionable value) xmltv source.

 Some discussion occurred here:
 https://sourceforge.net/p/xmltv/mailman/message/35107996/

 While the particular case which was identified above has been addressed
 upstream (although another recently occured), this patch also addresses
 the MythTV reported errors by changing the INSERT to INSERT IGNORE to meet
 the xmltv definition.  Note that (for alternative reasons) the (legacy)
 datadirect guide loader also uses INSERT IGNORE, so there is precedent to
 ignore duplicates.

 This patch has been lightly tested with manually manipulated source xmltv
 source file and appears to work as expected.

 For what little it is worth I consider this very low priority, as the root
 issue is (usually) poor source guide data, and the messages are not fatal
 (just informatory).



 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/660272784c2cdf2485f3c9345416b24720ae5f1e

 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/660272784c2cdf2485f3c9345416b24720ae5f1e.patch

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12914>
MythTV <http://www.mythtv.org>
MythTV Media Center