[mythtv-commits] Ticket #12763: Themechooser parses version number incorrectly

[MythTV]

#12763: Themechooser parses version number incorrectly
---------------------------------------------+---------------------
     Reporter:  Peter Bennett <pgbennett@…>  |      Owner:
         Type:  Bug Report - General         |     Status:  new
     Priority:  minor                        |  Milestone:  unknown
    Component:  MythTV - General             |    Version:  0.28.0
     Severity:  medium                       |   Keywords:
Ticket locked:  0                            |
---------------------------------------------+---------------------
 I have mythtv version v0.28-61-g5af4b41 and the backend displays 61 error
 messages when it starts up:
 {{{
 2016-05-10 11:21:09.927411 I  Running HouseKeeperTask
 'ThemeUpdateNotifications'.
 2016-05-10 11:21:09.927471 I  Loading themes for 0.28
 2016-05-10 11:21:10.776129 I  Loading themes for 0.28.61
 2016-05-10 11:21:10.976677 I  HouseKeeper: Failed to download
 http://themes.mythtv.org/themes/repository/0.28.61/themes.zip remote
 themes info package.
 }}}
 That 0.28.61 messages are repeated with numbers going down to 0.28.1.
 This seems to be caused by parsing the "-61" in the version string as if
 it was ".61"
 This will likely also affect the front end, which duplicates some code.

 mythtv/programs/mythfrontend/themechooser.cpp#L202

 mythtv/programs/mythbackend/backendhousekeeper.cpp#L366

 Also it would be good to refactor the code so that it is not duplicated.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12763>
MythTV <http://www.mythtv.org>
MythTV Media Center