[mythtv-commits] Ticket #12599: AllowTagWriting setting default mismatch

[MythTV]

#12599: AllowTagWriting setting default mismatch
--------------------------------------------+-------------------------
     Reporter:  Mike Rice <mikerice1969@…>  |      Owner:  paulh
         Type:  Patch - Bug Fix             |     Status:  new
     Priority:  minor                       |  Milestone:  unknown
    Component:  Plugin - MythMusic          |    Version:  Master Head
     Severity:  low                         |   Keywords:
Ticket locked:  0                           |
--------------------------------------------+-------------------------
 Noticed this on my testbox with a brand new database.

 The settings screen uses a default of 1 for AllowTagWriting:

 int allowTagWriting = gCoreContext->GetNumSetting("AllowTagWriting", 1);

 Therefore when it doesn't exist in the database yet the checkbox is
 checked, the user thinks he/she will be writing to tags, and won't think a
 save is needed.

 The uses of the setting in editmetadata.cpp and musicplayer.cpp use 0 as
 the default:

 if (GetMythDB()->GetNumSetting("AllowTagWriting", 0))

 So until that settings screen is saved the AllowTagWriting functionality
 will not be enabled even though it looks like it on the settings screen.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12599>
MythTV <http://www.mythtv.org>
MythTV Media Center