[mythtv-commits] Ticket #12571: Theme url does not exist for lastest git version 0.28-pre

MythTV noreply at mythtv.org
Fri Jan 1 20:32:03 UTC 2016


#12571: Theme url does not exist for lastest git version 0.28-pre
-------------------------------------------------+-------------------------
 Reporter:  William L. DeRieux IV                |          Owner:  stuarta
  <williamderieux@…>                             |
     Type:  Bug Report - General                 |         Status:  closed
 Priority:  minor                                |      Milestone:  0.28
Component:  Services - Theme Downloads           |        Version:  Master
                                                 |  Head
 Severity:  high                                 |     Resolution:  Works
                                                 |  for me
 Keywords:                                       |  Ticket locked:  0
-------------------------------------------------+-------------------------

Comment (by William L. DeRieux IV <williamderieux@…>):

 Replying to [comment:8 William L. DeRieux IV <williamderieux@…>]:
 > Replying to [comment:7 paulh]:
 > > It would still be interesting to see the version and branch reported
 on the 'About' popup on the main menu since it prints the same string the
 theme chooser users to decide which branch we are on and thus which themes
 are valid.
 > >
 > > I know in the past we have had problems with some distros messing with
 the version string that was causing problems.
 >
 > The reported branch was master

 It just occurred to me why this happened on only my system (but not on the
 copy a compiled yesterday)....
 It's because the .git folder was missing -- as far as git was concerned I
 did not have valid git working copy.

 That means version.sh would set MYTH_SOURCE_PATH to an empty string
 and MythVersion never got set to trunk in themechooser.cpp.

 I guess the simplest solution would be to modify line 157 in
 themechooser.cpp
 if MythVersion is an empty string it should probably be set to trunk.

 {{{
     // Treat devel branches as master
     if (MythVersion.isEmpty() || !MythVersion.startsWith("fixes/"))
         // FIXME: For now, treat git master the same as svn trunk
         MythVersion = "trunk";
 }}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12571#comment:9>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list