[mythtv-commits] Ticket #12456: Always display closed captioning or subtitles broken.

[MythTV]

#12456: Always display closed captioning or subtitles broken.
---------------------------------------+--------------------------
 Reporter:  eliteforce82nd@…           |          Owner:  pbennett
     Type:  Bug Report - General       |         Status:  accepted
 Priority:  minor                      |      Milestone:  0.27.7
Component:  MythTV - General           |        Version:  0.27.4
 Severity:  medium                     |     Resolution:
 Keywords:  Closed Captions Subtitles  |  Ticket locked:  0
---------------------------------------+--------------------------

Comment (by pbennett):

 The field textDesired indicates that subtitles should be activated, but
 when the mythplayer discovers no subtitles (because they have not yet been
 detected) it turns that flag off. Change to turn the flag off only if the
 operator requested to turn off subtitles or captions. Detect that the
 operator requested it by using the osd_msg flag, i.e. the operator is
 being notified that they are turned off.

 Here is the fix in my repository:

 https://github.com/bennettpeter/mythtv/commit/2225fdf44944b3f860d1252dbaf60c5d43fdd55f

 I will commit it to MythTV in a couple of days.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12456#comment:12>
MythTV <http://www.mythtv.org>
MythTV Media Center