[mythtv-commits] Ticket #12720: PR for Services API Adding SetSavedBookmark and GetSavedBookmark to Dvr Services PR #117
MythTV
noreply at mythtv.org
Mon Apr 11 03:43:01 UTC 2016
#12720: PR for Services API Adding SetSavedBookmark and GetSavedBookmark to Dvr
Services PR #117
-------------------------------------------------+-------------------------
Reporter: mitch.capper@… | Owner:
Type: Patch - Feature | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Services API - Backend | Version: Master Head
Severity: medium | Keywords:
Ticket locked: 0 |
-------------------------------------------------+-------------------------
https://github.com/MythTV/mythtv/pull/117
This PR adds two functions GetSavedBookmark and SetSavedBookmark they were
done largely in the style of #12090. I thought about adding the ability to
pull the full markup (in fact I am not sure the other GetRecordedCutList
shouldn't do this and let the user sort the types out) but this still left
how best to set a bookmark without adding a more complex markup setting
function.
I think this simplified version of just Get/Set bookmark adds the
remaining missing hunk to the services api for markup, no it doesn't add
the metadata of #11491 but that probably should come from elsewhere.
Both functions take very similar args to #12090.
I did refactor the QueryKeyFramePosition and QueryKeyFrameDuration main
function code into one function, as I was adding two more
(QueryPositionKeyFrame,QueryDurationKeyFrame) and they were nearly
identical I figured I would slim down the code. If you prefer 4 functions
with duplicate code however I can update the code for that.
--
Ticket URL: <https://code.mythtv.org/trac/ticket/12720>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list