[mythtv-commits] mythtv branch master updated by stuartm. v0.28-pre-2782-g0564713

Git Repo Owner noreply at mythtv.org
Mon Mar 30 19:46:19 UTC 2015


The branch, master has been updated on the
mythtv repository by gitolite user stuartm.
       via  05647132c2285a6d58e9afe7318f2bc50a14e3aa (commit)
      from  119fb55cd31f942b74900ffc0aeecbae5ebcb986 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 05647132c2285a6d58e9afe7318f2bc50a14e3aa
Author:    Stuart Morgan <smorgan at mythtv.org> at Fri, 27 Mar 2015 17:49:43 +0000
Committer: Stuart Morgan <smorgan at mythtv.org> at Mon, 30 Mar 2015 20:45:27 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=05647132c2285a6d58e9afe7318f2bc50a14e3aa

Services API: Fix a logical issue with GetProgramGuide
GetProgramGuide took an argument - StartChanId but since the list of
channels is sorted by the Channel Number, and not it's ID this made no
sense. This meant there was no way of restricting the results to just
a subset (page) of the guide.

So to address this issue, and make GetProgramGuide consistent with
other service API methods StartChanId has been replaced with
StartIndex, and NumChannels has been replaced with Count.

'TotalAvailable' is included in the results, but for now it will only
contain zero. A fix for this will be committed soon, I hope.

Unfortunately, the changes to make this necessary have negated the
earlier performance improvements. Fetching the complete guide is now
25-50% slower than it was before this commit, this is obviously not
acceptable and I'm trying a variety of approaches to get performance
back at least to where it was. On the other hand, since data can now
be fetched in ranges, perceived loading time can be reduced by
backgrounding the loading of most of the guide.



-----------------------------------------------------------------------

Summary of changes:
 mythtv/html/tv/guide.qsp                           |    2 +-
 .../datacontracts/programGuide.h                   |   40 ++---
 .../services/guideServices.h                       |    6 +-
 mythtv/libs/libmythtv/channelutil.cpp              |   30 +++-
 mythtv/libs/libmythtv/channelutil.h                |   12 +-
 mythtv/programs/mythbackend/services/channel.cpp   |   14 +-
 mythtv/programs/mythbackend/services/guide.cpp     |  173 +++++++++-----------
 mythtv/programs/mythbackend/services/guide.h       |   16 +-
 8 files changed, 149 insertions(+), 144 deletions(-)

-- 



More information about the mythtv-commits mailing list