[mythtv-commits] Ticket #12345: Recording Profile Group mappings are broken

[MythTV]

#12345: Recording Profile Group mappings are broken
--------------------------------------+-------------------------
     Reporter:  stuartm               |      Owner:
         Type:  Bug Report - General  |     Status:  new
     Priority:  blocker               |  Milestone:  0.28
    Component:  MythTV - General      |    Version:  Master Head
     Severity:  medium                |   Keywords:
Ticket locked:  0                     |
--------------------------------------+-------------------------
 It look as though at some point, when doing a schema rollup a mistake was
 made with the ProfileGroup IDs. For reasons we don't need to get into IDs
 9,10 & 11 were skipped when numbering the groups. However when the rollup
 was performed they were written sequentially so that groups ID > 8 and <
 15 were misnumbered.

 In databases newer than 2008, the following groups:
 {{{
         FreeboxGroup         = 12,
         HDHomeRunGroup       = 13,
         CRCIGroup            = 14,
         ASIGroup             = 15,
         OCURGroup            = 16,
         CetonGroup           = 17
 }}}

 are instead numbered as follows in the database:
 {{{
 | 10 | Freebox Input                                            |
 | 11 | HDHomeRun Recorders                                      |
 | 12 | CRC IP Recorders                                         |
 | 13 | HD-PVR Recorders                                         |
 | 14 | Import Recorder                                          |
 | 15 | ASI Recorder (DVEO)                                      |
 | 16 | OCUR Recorder (CableLabs)                                |
 | 17 | Ceton Recorder                                           |
 }}}

 As becomes obvious from the above, some profile groups were also invented
 which have no corresponding place in the enum in recordingprofile.h.

 Fixing this is going to be painful. Users from pre Dec 2008 will have a
 different values and recording profile mappings to those post Dec 2008.

 There is an opportunity here however to rip out this code for good. For
 starters, we should never have been storing translatable strings in the
 database (profilegroups). The current recordingprofile code is very slow
 and is invoked repeatedly during livetv channel changes. The whole thing
 is both extremely hard to maintain and managing profiles doesn't offer a
 very good UX for the end-user.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12345>
MythTV <http://www.mythtv.org>
MythTV Media Center