[mythtv-commits] Ticket #12385: Patch: Suggest that mythtranscode shouldn't always remove the original file

[MythTV]

#12385: Patch: Suggest that mythtranscode shouldn't always remove the original file
----------------------------------------+-------------------------
     Reporter:  Bill Meek <keemllib@…>  |      Owner:  jyavenard
         Type:  Patch - Bug Fix         |     Status:  new
     Priority:  minor                   |  Milestone:  unknown
    Component:  MythTV - Mythtranscode  |    Version:  Master Head
     Severity:  medium                  |   Keywords:
Ticket locked:  0                       |
----------------------------------------+-------------------------
 changeset:3d64f8a now calls CompleteJob() for all types of
 transcodes.

 When using --hlsstreamid, the output goes to the Streaming
 Storage Group and the original file(s) shouldn't be removed.

 Currently, the following happens (there is no .tmp file):
 {{{
 mythtranscode: about to rename
 '/srv/mythtv-0/recordings/2609_20150217165800.ts' to
 '/srv/mythtv-0/recordings/2609_20150217165800.ts.old'
 mythtranscode: About to unlink/delete file:
 /srv/mythtv-0/recordings/2609_20150217165800.ts.old
 }}}

 Patch tested on v0.28-pre-2670-g3d05b39-dirty. I'm not sure
 if the test should be for --hls or --hlsstreamid. Either
 works for the Content/AddLiveStream endpoint and I believe
 cares for the original intent to handle command line xcodes.
 {{{
 diff --git a/mythtv/programs/mythtranscode/main.cpp
 b/mythtv/programs/mythtranscode/main.cpp
 index 8c84813..a01acde 100644
 --- a/mythtv/programs/mythtranscode/main.cpp
 +++ b/mythtv/programs/mythtranscode/main.cpp
 @@ -748,7 +748,8 @@ int main(int argc, char *argv[])
          exitcode = result;
      }

 -    CompleteJob(jobID, pginfo, useCutlist, &deleteMap, exitcode, result);
 +    if (!cmdline.toBool("hlsstreamid"))
 +        CompleteJob(jobID, pginfo, useCutlist, &deleteMap, exitcode,
 result);

      transcode->deleteLater();

 }}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12385>
MythTV <http://www.mythtv.org>
MythTV Media Center