[mythtv-commits] mythtv branch devel/lvr/bugfixes created by lvr. v0.28-pre-3372-g880d6e8
Git Repo Owner
noreply at mythtv.org
Wed Dec 30 16:52:36 UTC 2015
The branch, devel/lvr/bugfixes has been created on the
mythtv repository by gitolite user lvr.
at 880d6e88291c773bde552e4f7610cbaaba23219c (commit)
- Log -----------------------------------------------------------------
commit 880d6e88291c773bde552e4f7610cbaaba23219c
Author: Lawrence Rust <lvr at softsystem.co.uk> at Thu, 5 Nov 2015 13:54:33 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:23 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=880d6e88291c773bde552e4f7610cbaaba23219c
Fix link failure due to incorrect MBASE_PUBLIC used by mythgesture in libmythui
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 11127683ca7abc28a9c7563627f9a691aeb81fb6
Author: Lawrence Rust <lvr at softsystem.co.uk> at Tue, 3 Nov 2015 14:05:34 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:23 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=11127683ca7abc28a9c7563627f9a691aeb81fb6
TV: Ensure correct A/V sync with PBP
When there are 2 PBP players TV::PlaybackLoop calls player->VideoLoop for
each instance. However, both players wait for VSync causing the primary
PBP to lose A/V sync.
This patch only waits for VSync in the primary PBP player (which has
sound).
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit e59c71867796d08a11e6ef841425cd039b6bee94
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sun, 11 Oct 2015 17:49:58 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:23 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=e59c71867796d08a11e6ef841425cd039b6bee94
Player: Allow user to change deinterlacer when time stretch > 1.0
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit f6c12c71e7b0607f656feffd54af9b8a53936913
Author: Lawrence Rust <lvr at softsystem.co.uk> at Tue, 1 Sep 2015 13:50:05 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:23 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=f6c12c71e7b0607f656feffd54af9b8a53936913
OpenGL: Fix colour rendition when using opengllite profile on Mesa
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 3a3b1c49eef56c0e9a2422ce1386986340873cfc
Author: Lawrence Rust <lvr at softsystem.co.uk> at Mon, 31 Aug 2015 15:42:31 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=3a3b1c49eef56c0e9a2422ce1386986340873cfc
FE: avoid a null ptr deref when updating 'Search Listings' items
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit a7b48619a495f23d646762da1e3d7d2bdae22116
Author: Lawrence Rust <lvr at softsystem.co.uk> at Thu, 11 Jun 2015 16:58:29 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=a7b48619a495f23d646762da1e3d7d2bdae22116
MythNews: Ignore enclosures that have no valid type
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit b1281e70d4e3a9968942322c63d310f7204d5a0b
Author: Lawrence Rust <lvr at softsystem.co.uk> at Fri, 22 May 2015 08:54:03 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=b1281e70d4e3a9968942322c63d310f7204d5a0b
UI: Avoid adding NULL values to MythUIButtonList::m_ButtonToItem
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 28c765b0763204dd32c3f986237e22a39ded4a7d
Author: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 13 May 2015 13:59:10 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=28c765b0763204dd32c3f986237e22a39ded4a7d
Fix bcd7d65e to use UTF8 string for MYTH_PROTO_TOKEN
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 4c68a62dc36cb7a683100c6abe86787e350921ff
Author: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 15 Apr 2015 20:40:32 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=4c68a62dc36cb7a683100c6abe86787e350921ff
Setup: Fix regex detecting V4L video device
mythtv-setup, add new capture card was failing to find /dev/video
and add it to the video device combo box
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit c5ea578e22cb5e776a962cc617e1c58aa2f518d4
Author: Lawrence Rust <lvr at softsystem.co.uk> at Tue, 31 Mar 2015 14:28:44 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=c5ea578e22cb5e776a962cc617e1c58aa2f518d4
UI: Ensure MythConfirmationDialog only posts one DialogCompletionEvent
In the FE select a recording rule and press 'D' to delete. Press
and hold Esc and sometimes you get an abort in glibc about freeing
an unallocated block:
0 0xb7710c5c in __kernel_vsyscall ()
No symbol table info available.
1 0xb5055e0f in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
resultvar = <optimised out>
resultvar = <optimised out>
pid = -1256398860
selftid = 6138
2 0xb5059455 in __GI_abort () at abort.c:91
save_stage = 2
act = {__sigaction_handler = {sa_handler = 0x107, sa_sigaction = 0x107}, sa_mask = {__val = {134513596, 3037875353, 0, 24,
2, 3037785874, 0, 0, 4, 3217048212, 3038568436, 22, 3217049748, 3037907354, 41, 3217048212, 4, 0, 3217053020, 0, 3,
0, 6, 3217048316, 3217048308, 4, 3038296081, 3038296085, 3036943328, 3, 3036943571, 4}}, sa_flags = 5,
sa_restorer = 0xb5189294}
sigs = {__val = {32, 0 <repeats 31 times>}}
3 0xb50926ea in __libc_message (do_abort=2, fmt=0xb518dba8 "*** glibc detected *** %s: %s: 0x%s ***\n")
at ../sysdeps/unix/sysv/linux/libc_fatal.c:201
ap = 0xad6ce000 ""
ap_copy = 0xad6ce000 ""
fd = 41
on_2 = <optimised out>
list = <optimised out>
nlist = <optimised out>
cp = <optimised out>
written = <optimised out>
4 0xb509d232 in malloc_printerr (action=<optimised out>, str=<optimised out>, ptr=0xd130f80) at malloc.c:5047
buf = "0d130f80"
cp = <optimised out>
5 0xb529951f in operator delete(void*) () from /usr/lib/i386-linux-gnu/libstdc++.so.6
No symbol table info available.
6 0x08109877 in ProgramRecPriority::customEvent (this=0x95609c0, event=0xd130f80) at programrecpriority.cpp:841
record = 0xd130f80
resultid = {d = 0x91948a8}
resulttext = {d = 0xb55b048c}
buttonnum = 0
__FUNCTION__ = "customEvent"
This appears to happen in ProgramRecPriority::remove which puts up
a MythConfirmationDialog. If sendResult() is called multiple times
then ProgramRecPriority::customEvent (deleterule) can delete the same
RecordingRule* over again.
This patch ensures a single DialogCompletionEvent by setting m_retObject
to NULL in MythConfirmationDialog::sendResult.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 547b34daba0d40bf0573f7d2652f38edf52bb443
Author: Lawrence Rust <lvr at softsystem.co.uk> at Mon, 30 Mar 2015 18:17:18 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=547b34daba0d40bf0573f7d2652f38edf52bb443
UI: Ensure the UI idle timer is start/stopped from the UI thread
MythMainWindow::PauseIdleTimer is called from many places none of
which are guaranteed to be running on the main UI thread. Qt
requires that timers are start/stopped from the same thread that
created them otherwise the operation will fail.
MusicPlayer::stop() calls MythMainWindow::PauseIdleTimer from
PlaylistLoadingThread which tickles this bug.
This patch causes the start/stop timer methods to be invoked
using QMetaObject which guarantees this requirement.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 3ff59e2710b620e0c7d77d140eedf15fa1a144d3
Author: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 18 Mar 2015 16:52:15 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=3ff59e2710b620e0c7d77d140eedf15fa1a144d3
BE: Avoid SEGV when accessing discarded MythSocket
1. When a client connects, MainServer::NewConnection is called which
inserts a new MythSocket in controlSocketList.
2. When data is received, MainServer::readyRead creates a new thread to
process the request and saves the MythSocket to read from.
3. If the client disconnects before the thread handles the request then
the MythSocket is added to decrRefSocketList and removed from
controlSocketList.
4. When the thread runs and handles an 'ANN' request it creates a
PlaybackSock that references the MythSocket.
5. When MainServer::customEvent runs, it deletes any MythSockets
listed in decrRefSocketList. This results in the PlaybackSock having
a dangling reference to the socket. If the event is to be broadcast,
all client PlaybackSock's are sent the message which results in a reference
to the deleted socket and a SEGV.
This fix adds a test in MainServer::ProcessRequestWork to ensure the
socket is still in the controlSocketList and some additional code
in MainServer::HandleAnnounce to also check controlSocketList before
a PlaybackSock is created.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 9c29c233d7b6a84224d9f8886147d87340b73e5a
Author: Lawrence Rust <lvr at softsystem.co.uk> at Thu, 12 Mar 2015 15:09:28 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=9c29c233d7b6a84224d9f8886147d87340b73e5a
MPEG: Allow TV programs to be recorded 'Audio Only'
If a program is recorded with the 'audio only' profile and it has a
video stream in the source then get no output and lots of these log messages:
DTVRec[1]: ProcessVideoTSPacket: unknown stream type!
This patch initialises _pid_video_single_program which otherwise will
contain stale data.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 93a6c2f55bd4ab2617812ac3114f47533e20b468
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sat, 17 Jan 2015 11:18:39 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=93a6c2f55bd4ab2617812ac3114f47533e20b468
MythTranscode: Reset the video stream ID before generating keyframe index
The ID of the video stream in the transcoded file may not be the
same as that in the input file. Generally this is the case
and most transcodes generate a correct keyframe index. However,
some channels (e.g. UK Freeview horror channel) have audio as the
first channel in the input file. In this case, lossless transcode
makes the first stream video and so the keyframe index generation
is incorrect.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 9648dcffce5f1302d0333b6ca4acf44599443559
Author: Lawrence Rust <lvr at softsystem.co.uk> at Fri, 16 Jan 2015 15:11:07 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=9648dcffce5f1302d0333b6ca4acf44599443559
Logging: Fix -V option handling to accept 64bit values
At present passing VB_xxx options >= 1<<32 causes verboseMask to
be set to 0 and disable all logging. This affects mythtranscode
when passed %VERBOSELEVEL% option.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 6399cddda4a7326848c861a4352b0177015eeedd
Author: Lawrence Rust <lvr at softsystem.co.uk> at Tue, 6 Jan 2015 16:38:38 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=6399cddda4a7326848c861a4352b0177015eeedd
FE: Avert a race condition in program guide updating
If a GuideHelper thread is running then a SCHEDULE_CHANGE event can
update GuideGrid::m_recList which is iterated by the GuideHelper thread
and cause an access violation.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 087d1e0bb7e6fa93562af4e0f4c0f9a9e7fe2d6a
Author: Lawrence Rust <lvr at softsystem.co.uk> at Tue, 30 Dec 2014 18:48:59 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:22 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=087d1e0bb7e6fa93562af4e0f4c0f9a9e7fe2d6a
mythsystemunix: Fix race condition in MythSystemLegacy::Run
After a child process is created in MythSystemLegacyUnix::Fork there
is a small time interval before MythSystemLegacy::Run calls
MythSystemLegacyUnix::Manage to add the process to
MythSystemLegacyManager's active queue. If the child should terminate
before this then MythSystemLegacy::Wait can deadlock.
This fix acquires a mutex shared with MythSystemLegacyManager before
the fork operation and releases it after the process has been added
to the queue.
Additionally preserve the values of the pipe ends that are shared
with the child process.
The race condition and subsequent deadlock were observed in mythshutdown
with the --setwakeuptime option. This prevented the BE shutting down
when idle and deadlocked the main BE thread.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit bb771e148792fcaa2cda087d5bc9d368488bfa75
Author: Lawrence Rust <lvr at softsystem.co.uk> at Mon, 8 Sep 2014 17:37:17 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=bb771e148792fcaa2cda087d5bc9d368488bfa75
Configure: Fix reference to unset variable in check_class_headers_cpp
This bug causes the compilation of ffmpeg.c to fail because
HAVE_GETPROCESSMEMORYINFO is set in config.h, causing windows.h
to be #include'd.
GetProcessMemoryInfo is enabled by check_class_headers_cpp which
erroneously calls 'enable $funcs' when $funcs has the stale value
GetProcessMemoryInfo.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 7f0486a2515383d88d06d0cebfc18ada3bce91fb
Author: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Jul 2014 18:54:30 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=7f0486a2515383d88d06d0cebfc18ada3bce91fb
TV: Fix DrawUnusedRects when exiting embedded EPG
When exiting the embedded EPG if the program material is in a
different format to the display then the theme borders are drawn
around the video.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 1cc00e7caae1118e0793c76fd2f31cb7f6f842bf
Author: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Jul 2014 15:56:21 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=1cc00e7caae1118e0793c76fd2f31cb7f6f842bf
TV: Avoid race condition when exiting if TV is embedded
When exiting the program guide with embedded TV to the main menu
there is a race condition between the TV instance being deleted
and the GuideHelper thread which updates the channel states but
uses the TV instance.
The fix is to call qApp->processEvents until the guide shuts down.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit e9b8d644f564ebdcb80e3678f80422661df6c003
Author: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 23 Jul 2014 14:52:40 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=e9b8d644f564ebdcb80e3678f80422661df6c003
FE: Playbackbox - ensure stereo icon takes precedence over mono
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 96bba8e53a5f206603ddb14c6c5471ba2a7a2819
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sun, 20 Jul 2014 17:40:30 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=96bba8e53a5f206603ddb14c6c5471ba2a7a2819
EIT: Ensure names in the people dbase table are stripped of trailing spaces
EITFixUp::FixUK can add names with a trailing space. It is then
non-obvious why Search-Listings/People fails.
The people dbase table can be cleaned with:
mysql -e"update people set name = rtrim(name) where name like '% '"
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 50dd194ec3a102f18b895cb0ba27c8f1e2edd336
Author: Lawrence Rust <lvr at softsystem.co.uk> at Fri, 18 Jul 2014 14:12:25 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=50dd194ec3a102f18b895cb0ba27c8f1e2edd336
TV: Fix out of bounds array access in spectrum visualizer
NB This was the cause of the 'sticky bars' often seen with this visualiser
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 8fdfba5d9d07fb3c1adae1058ef3360143598068
Author: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 16 Jul 2014 12:36:19 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=8fdfba5d9d07fb3c1adae1058ef3360143598068
Fix 0b9470c Fix fileringbuffer locking...
Commit 0b9470c (Fix fileringbuffer locking up on read()) modified
FileRingBuffer::safe_read to use fstat() to check the file size
before reading. The new code compares (internalreadpos + tot)
with the reported size. This is correct except when
MythPlayer::SwitchProgram detects the transition across a livetv
programme boundary. In this case internalreadpos holds the read
position for the old file until the decoder calls FileChanged().
This patch includes readAdjust (set by SetAdjustFilesize()) to
correctly determine the current read position in the file.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 93fd92d2c1843768284779950da1bcb01cd3397a
Author: Lawrence Rust <lvr at softsystem.co.uk> at Thu, 10 Jul 2014 11:19:46 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=93fd92d2c1843768284779950da1bcb01cd3397a
mythcommflag: Prevent a divide by zero exception
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 974a96c5e3842eee8e62599555683d7bb3aea06d
Author: Lawrence Rust <lvr at softsystem.co.uk> at Fri, 20 Jun 2014 13:50:04 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=974a96c5e3842eee8e62599555683d7bb3aea06d
Videobuffers: Fix GetStatus to report correct video frame status
When using PiP or PbP there are more than 32 buffers in use which
causes GetStatus to show the wrong status.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 84cd6f90cbafc6eb35a79f259b2c3c55820db2f7
Author: Lawrence Rust <lvr at softsystem.co.uk> at Tue, 10 Jun 2014 10:44:43 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=84cd6f90cbafc6eb35a79f259b2c3c55820db2f7
Mythwelcome: Disable the idle standby timer
Mythwelcome normally connects to the BE in non-blocking mode i.e. the BE
is free to shutdown when it's idle.
If mythwelcome is active and the MythMainWindow idle timer fires then
standby state is entered. On the next key press, e.g. to start the FE,
standby mode is exited and gCoreContext->BlockShutdown is called which
prevents the BE from shutting down even when the FE enters standby. The
block is not released until the FE exits and an idle timeout occurs in
mythwelcome.
Mythwelcome has no need for standby mode so disable the idle timer
during application startup.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 78d0c0574c53ee9e8c1e0f2eb716e7c685aa92ed
Author: Lawrence Rust <lvr at softsystem.co.uk> at Mon, 13 Jan 2014 13:50:32 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=78d0c0574c53ee9e8c1e0f2eb716e7c685aa92ed
MPEG: Correctly handle PSIP packets with StartOfFieldPointer 178..180
PSIP packets with StartOfFieldPointer in the range 178..180 are
incorrectly rejected.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 65b93382e527554da8804458518f01ad0357460e
Author: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 8 Jan 2014 19:03:06 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:21 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=65b93382e527554da8804458518f01ad0357460e
Player: Restore the cutlist editor after seeking across a video format change
A change in video format results in a call to MythPlayer::ReinitOSD
which reinitialises the OSD for the new video bounds. However, if the
cutlist editor is active its window is left hidden until the user presses
a key.
This patch calls deleteMap.UpdateOSD from ReinitOSD to restore the window
and its contents. NB deleteMap must be marked as changed for the
cut regions to be redrawn.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit dbb6b1a3e1850e1604f75547060b0de65939e079
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sat, 28 Dec 2013 12:36:08 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=dbb6b1a3e1850e1604f75547060b0de65939e079
TV: Ensure LiveTV channel number is updated when changing channel on same mux
When changing LiveTV channel from a DTV source, TVRec::TuningFrequency
checks if the new channel is on the same multiplex and if so it
skips the tuning operation and restarts the recorder. Unfortunately
this means that the new ringbuffer filename will use the old channel
number. This in turn means that the FE will use the wrong channel
number when disping OSD info.
This patch updates the channel number before restarting the recorder.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit c979c3e1139941f26f10b137b77bd09dc3be9d6e
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sat, 21 Dec 2013 20:57:45 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=c979c3e1139941f26f10b137b77bd09dc3be9d6e
FE: Ensure FE re-connects to BE in monitor mode if FE is in standby
The BE doesn't powerdown sometimes when the FE is in standby as BE sees
an open playback connection. Appears that after the BE suspends and then
resumes the FE re-connects to the BE in playback (blocking) mode.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit e4898f994957536547b9895aeb45d9798f79cc85
Author: Lawrence Rust <lvr at softsystem.co.uk> at Fri, 20 Dec 2013 20:25:41 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=e4898f994957536547b9895aeb45d9798f79cc85
VO: Permit change of deinterlace method while playing
During playback there is a UI menu to select the deinterlace method.
However, VideoOutput::SetupDeinterlace does nothing if the interlacing
state is not changed. This means the user is unable to change the
deinterlace filter during playback.
This patch adds an additional test to VideoOutput::SetupDeinterlace
to allow a new deinterlace filter to be chosen.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 4be0852e207d0e9c3775f78f858ada08e9897e11
Author: Lawrence Rust <lvr at softsystem.co.uk> at Thu, 14 Nov 2013 17:55:19 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=4be0852e207d0e9c3775f78f858ada08e9897e11
mythtranscode: prevent an OOM abort caused by over allocating buffers
Using mythtranscode to output to FIFOs can sometimes result in an OOM
abort caused by dynamically allocating output buffers in
FIFOWriter::FIFOWrite. At present there is no limit on the number
of buffers allocated. If the FIFO read process is slow and the
video output rate is low then decoded audio packets can exhaust memory.
This patch adds an upper limit to the number of output buffers.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit e6e68f6a51df84cc10c868d9567a1418a6f4fee2
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sun, 27 Oct 2013 16:40:44 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=e6e68f6a51df84cc10c868d9567a1418a6f4fee2
VO: Prevent VAAPI scibbling in CropToDisplay
When using VAAPI decoding, VideoOutputOpenGLVAAPI::ProcessFrame is
called from MythPlayer::VideoLoop to display a frame. This in turn
calls VideoOutputOpenGL::ProcessFrame which calls VideoOutput::CropToDisplay
However, this function only handles YV12 format frames and not VAAPI
format and can write beyond the end of the video buffer.
This patch checks the frame codec and returns early if the format
is not YV12. This does not affect any other formats as OpenGL
normally uses YV12 format.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit b7261f844a3903d685faf6f057c3d05f21bc43ce
Author: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 23 Oct 2013 19:42:46 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=b7261f844a3903d685faf6f057c3d05f21bc43ce
Libmythbase: Stop MythWelcome blocking BE idle shutdown
MythWelcome connects to the backend server using a "Monitor"
announcement so as not to block backend idle shutdown. However,
if the connection is broken for whatever reason e.g. if the
backend is stopped during STR, then when the connection is
re-established it currently uses "Playback" mode if the idle
shutdown time is > 0. This causes the MythWelcome connection
to block further idle shutdowns.
This fix passes the original blocking mode to ConnectToMasterServer
rather than idleTimeoutSecs > 0
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 797145d93dcdef12f14b9319e374dfe86f685f3b
Author: Lawrence Rust <lvr at softsystem.co.uk> at Mon, 7 Oct 2013 11:09:22 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=797145d93dcdef12f14b9319e374dfe86f685f3b
Visualisers: handle float32 audio samples
Ogg and wma audio recordings are passed to the visualiser as
32-bit floating point buffers which are currently incorrectly
displayed.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 9c51f5b8426d107779e6cb379f6c8e79afb723c7
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sat, 28 Sep 2013 14:28:46 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=9c51f5b8426d107779e6cb379f6c8e79afb723c7
AFD: Fix playback of MPEG1 recordings with Xv and VAAAPI
1. Ffmpeg's avcodec_open2 fails if the stream's type doesn't match
the decoder's type. This patch forces the codec type to mpeg2 as
well as the stream to work around this limitation.
2. Ffmpeg cannot decode MPEG1 to a VAAPI supported pixel format so it
is necessary for VAAPI to refuse to handle an MPEG1 stream. In this
case the decoder will fallback to Xvideo.
Without this patch the playback of mpeg1 videos is broken.
This bug affects older videos and cameras using MPEG1 encoding.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit c948145e338dac36285a1cbe00ed019ade76d0db
Author: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 11 Sep 2013 17:52:00 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=c948145e338dac36285a1cbe00ed019ade76d0db
TV: Move ownership of the AudioOutputSync setting to PlayerContext
Currently the audio sync offset is setup in the MythPlayer ctor from
the AudioSyncOffset dbase setting. However, this means that all
users of MythPlayer, including the transcoder, use the same offset.
This is OK for recordings and liveTV (where the user has interactively
set the value based on observed delays) but adversely affects transcoding
which results in permanent A/V offsets.
This patch moves ownership of AudioSyncOffset from MythPlayer
to PlayerContext. PlayerContext sets the offset in StartPlaying and saves
it in StopPlaying.
Also the offset is set to 0 when using the cutlist editor to ensure
synchronisation between the audio output graph and the pause frame.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit dd5e169c56b7b73100019c2e33a180b4fb45834c
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sun, 24 Jul 2011 13:13:41 +0200
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=dd5e169c56b7b73100019c2e33a180b4fb45834c
TV: Move thread affinity of PreviewGenerator objects to QApplication
If viewing a recorded program using a debug build of Qt, then when the
recording comes to an end the following assert is often triggered:
ASSERT failure in QCoreApplication::sendEvent: "Cannot send events to
objects owned by a different thread. Current thread a24e070.
Receiver '' (of type 'PreviewGenerator') was created in thread ac2f84b8",
file kernel/qcoreapplication.cpp, line 349
Qt requires that an event receiver have the same thread affinity as the
QThread sending the event and this mechanism is used to dispatch
MythEvents sent by gCoreContext->dispatchNow(me)
This patch moves all PreviewGenerator objects to the QApplication::instance()
thread.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 615b3b4ce3f34288aa897285a715e7bbc8730590
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sat, 10 Aug 2013 17:32:12 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=615b3b4ce3f34288aa897285a715e7bbc8730590
MythWeather: Fix a SEGV on exit from setup screen
When starting with an empty database, select MythWeather from the
main menu. A blank screen is shown. Pressing back shows the setup
screen. Press back again to the main menu and the FE aborts:
Program terminated with signal 11, Segmentation fault.
0 SourceManager::clearSources (this=0x92c40f0) at sourceManager.cpp:156
156 while (!m_scripts.isEmpty())
0 SourceManager::clearSources (this=0x92c40f0) at sourceManager.cpp:156
1 0xa67497c9 in ScreenSetup::~ScreenSetup (this=0xb21cef0,
__in_chrg=<value optimised out>) at weatherSetup.cpp:110
2 0xa6749c40 in ScreenSetup::~ScreenSetup (this=0xb21cef0,
__in_chrg=<value optimised out>) at weatherSetup.cpp:130
3 0xb25969de in qDeleteInEventHandler (o=0xb21cef0)
at kernel/qobject.cpp:4277
When ScreenSetup's dtor is called, the m_sourceManager passed to the ctor
has already been deleted.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 16e69cb514260265e99a8cec1d5daa560057c53c
Author: Lawrence Rust <lvr at softsystem.co.uk> at Thu, 8 Aug 2013 17:09:16 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:20 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=16e69cb514260265e99a8cec1d5daa560057c53c
Settings: Initialise IntegerSetting to 0 in ctor
By default a setting is initialised to a null string which, if the user
does nothing else, results in an empty string written to the database.
This can cause some routines that test for a numeric value to fail e.g.
MythArchive's DVD creator fails if MythArchiveDriveSpeed is an empty string:
Traceback (most recent call last):
File "/home/lvr/Projects/myth/mythinstall/share/mythtv/mytharchive/scripts/mythburn.py", line 5247, in <module>
main()
File "/home/lvr/Projects/myth/mythinstall/share/mythtv/mytharchive/scripts/mythburn.py", line 5143, in main
drivespeed = int(defaultsettings.get("MythArchiveDriveSpeed", "0"))
ValueError: invalid literal for int() with base 10: ''
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 4f9f1e16087063a7f1b55a4756e6306db4f2c8cf
Author: Lawrence Rust <lvr at softsystem.co.uk> at Tue, 6 Aug 2013 18:51:27 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:19 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=4f9f1e16087063a7f1b55a4756e6306db4f2c8cf
BE: Fix SEGV in MpegRecorder::run when exiting LiveTV
Start FE live TV from demo recorder. Exit and BE crashes.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit f939376094b77e8d0be95c2726aac2db3065c40a
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sat, 3 Aug 2013 18:53:46 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:19 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=f939376094b77e8d0be95c2726aac2db3065c40a
OSD: Relax alignment settings for yuv888_to_yv12
The current checks on alignment for c_yuv888_to_yv12 are over restrictive
and can cause the OSD to not be displayed if using a window which has
an odd height e.g.1680x945.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 717e9fd653a1cc5b9fbd468288422676711d5a0a
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sun, 9 Jun 2013 10:16:22 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:19 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=717e9fd653a1cc5b9fbd468288422676711d5a0a
Mythsystem: Add a wait condition to speed up wait for completed children
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 761f24c50f0a780ed1745d9c395caa64416fc942
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sun, 14 Apr 2013 20:33:35 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:19 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=761f24c50f0a780ed1745d9c395caa64416fc942
TV: Prevent the live TV pop-up EPG from nesting and hanging the UI
If the 'start EPG' key (S) is pressed twice quickly right after starting
live TV then a Myth busy dialog box appears which can't be dismissed.
The problem is caused by attempting to start the pop-up EPG while it is
already active.
This patch checks if the pop-up is active and ignores the request if it is.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 59505e673568f552f03087bc6727ec2a5f510e5c
Author: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 7 Mar 2012 15:45:56 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:19 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=59505e673568f552f03087bc6727ec2a5f510e5c
TV: Fix race condition when changing channels with browse mode
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit fe26c7b1b3ab2f1207a8c3911e1c9ac4c088b045
Author: Lawrence Rust <lvr at softsystem.co.uk> at Sat, 9 Mar 2013 10:25:43 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:19 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=fe26c7b1b3ab2f1207a8c3911e1c9ac4c088b045
FE: Channel record priority settings gets channel icons from master BE
Channel icon paths are relative to the master BE. When a remote frontend
shows a channel icon the image is loaded locally which normally fails.
Aside: the TV guide correctly handles channel icons.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 5e8a1433af3b564b02e4d4f387901adea470bcc4
Author: Lawrence Rust <lvr at softsystem.co.uk> at Mon, 24 Jun 2013 11:07:49 +0100
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:19 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=5e8a1433af3b564b02e4d4f387901adea470bcc4
Player: Avoid a race condition when creating the InteractiveTV object.
There is a race condition bewtween the GUI and decoder threads
to create the interactiveTV object because the guarding mutex is
not acquired before reading the interactiveTV variable.
This often manifests itself to the user as an absence of interactive
text on recorded (but not liveTV) programs.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
commit 1ab4059a805a506b07ec0304315e2bd0a7cb1708
Author: Lawrence Rust <lvr at softsystem.co.uk> at Thu, 21 Mar 2013 14:40:10 +0000
Committer: Lawrence Rust <lvr at softsystem.co.uk> at Wed, 30 Dec 2015 16:16:19 +0000
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=1ab4059a805a506b07ec0304315e2bd0a7cb1708
TV: Prevent a SEGV in videooutputbase due to race condition
Both the UI thread and the interactive TV systems access MythPlayer's
videoOutput instance. This can cause problems if the UI is updating
the OSD and interactive TV calls MythPlayer::SetVideoResize. In
this case VideoOutput::vsz_tmp_buf can be deleted and set to NULL
while VideoOutput::ResizeVideo is executing.
In MythPlayer::SetVideoResize acquire osdLock before calling
videoOutput->SetVideoResize.
Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
-----------------------------------------------------------------------
--
More information about the mythtv-commits
mailing list