[mythtv-commits] Ticket #10740: [PATCH] libmythui: Fix an assert failure in Qt when playing a video
MythTV
noreply at mythtv.org
Sun Apr 12 15:42:47 UTC 2015
#10740: [PATCH] libmythui: Fix an assert failure in Qt when playing a video
-------------------------------------+----------------------------
Reporter: Lawrence Rust <lvr@…> | Owner: stichnot
Type: Patch - Bug Fix | Status: closed
Priority: minor | Milestone: 0.25.1
Component: MythTV - Video Playback | Version: 0.25-fixes
Severity: medium | Resolution: Fixed
Keywords: DVD assert | Ticket locked: 0
-------------------------------------+----------------------------
Comment (by Jim Stichnoth <jstichnoth@…>):
In [changeset:"ac3a988f2e9140322b1a15c34d6ac87071c69d7e/mythtv"]:
{{{
#!CommitTicketReference repository="mythtv"
revision="ac3a988f2e9140322b1a15c34d6ac87071c69d7e"
Subtitles: Fix automatic display of captions/subtitles.
There was something of a race condition in the previous code. At
startup of playback, the decoder thread runs ahead and updates track
lists as it encounters them, including audio, cc608, cc708, etc. If
no subtitle tracks are found before the UI thread gets to a certain
point, the UI thread commits to keeping subtitles disabled, regardless
of the "automatically display subtitles" setting.
In the new version, at startup of playback, the UI thread keeps the
original intention alive so that subtitles will automatically start
displaying when they eventually arrive.
Note that this fix doesn't address the problem where the player ought
to switch to a "better" subtitle track type when it comes along, such
as switching from cc608 to cc708.
Refs #10740 (only because this fixes a fix with that ref)
}}}
--
Ticket URL: <https://code.mythtv.org/trac/ticket/10740#comment:9>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list