[mythtv-commits] mythtv branch master updated by stuartm. v0.28-pre-2149-g18cd383

[Git Repo Owner]

The branch, master has been updated on the
mythtv repository by gitolite user stuartm.
       via  18cd3832585d3d993de9561f07885280c3c2ee8e (commit)
       via  cb54c9ce9bac3813a05a63601b4ee0b1f07e518c (commit)
       via  af9e316cdd31d09ac451a603918c83520d0a0596 (commit)
       via  2e486e80c33fa1a1b0ee62e7dff1d0298d77c7fa (commit)
      from  d6f1e2a89ce111efb38ffafa948c5f6b0bc40953 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 18cd3832585d3d993de9561f07885280c3c2ee8e
Author:    Stuart Morgan <smorgan at mythtv.org> at Thu, 4 Sep 2014 20:31:06 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Thu, 4 Sep 2014 22:45:51 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=18cd3832585d3d993de9561f07885280c3c2ee8e

Fix more IP vs hostname confusion in myth:// urls
A myth url consists of <group>@<hostname>:<port> where <hostname> is
the unique identifier of a backend, NOT an IP address. Some code
rightly expects to be able to extract the hostname from the URL and
use it as the unique identifier, for example to StorageGroup() or as a
key for DB lookups. The places where an IP was used broke this
assumption and caused the code to take an extended route to complete
it's task, or caused failures.

The 'hostname' will be converted to an IP address only at the point
where we connect to the remote backend to transfer/delete/etc the
file. Since only mythtv is expected to handle myth:// urls this is OK.

Since this has been causing confusion for some time there may be parts
of the code that incorrectly expect an IP address which will have to
be fixed.



commit cb54c9ce9bac3813a05a63601b4ee0b1f07e518c
Author:    Stuart Morgan <smorgan at mythtv.org> at Thu, 4 Sep 2014 19:28:29 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Thu, 4 Sep 2014 19:46:09 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=cb54c9ce9bac3813a05a63601b4ee0b1f07e518c

More accurate error message when an IP is passed to GetBackendServerIP() instead of a hostname



commit af9e316cdd31d09ac451a603918c83520d0a0596
Author:    Stuart Morgan <smorgan at mythtv.org> at Thu, 4 Sep 2014 16:55:48 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Thu, 4 Sep 2014 19:46:05 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=af9e316cdd31d09ac451a603918c83520d0a0596

Fix FindFile/FindFileLists using SendRecieveStringList() when accessed on Master Backend



commit 2e486e80c33fa1a1b0ee62e7dff1d0298d77c7fa
Author:    Stuart Morgan <smorgan at mythtv.org> at Thu, 4 Sep 2014 15:57:06 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Thu, 4 Sep 2014 19:45:54 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=2e486e80c33fa1a1b0ee62e7dff1d0298d77c7fa

Fix errors when loading music album art.
Use RemoteFile::exists() instead of FindFile, it's more appropriate
here and faster.

StorageGroup expects a hostname not an IP address, pass the hostname instead.



-----------------------------------------------------------------------

Summary of changes:
 mythtv/libs/libmyth/programinfo.cpp                |    4 +-
 mythtv/libs/libmythbase/mythcorecontext.cpp        |   19 +++++++++++++-
 mythtv/libs/libmythbase/remotefile.cpp             |   21 +++++++++-------
 .../libs/libmythmetadata/metadataimagedownload.cpp |    3 +-
 mythtv/libs/libmythmetadata/musicmetadata.cpp      |   13 +++++++---
 mythtv/libs/libmythmetadata/videoutils.h           |    3 +-
 mythtv/libs/libmythtv/metadataimagehelper.h        |    3 +-
 mythtv/libs/libmythtv/tv_rec.cpp                   |    2 +-
 mythtv/programs/mythbackend/mainserver.cpp         |   25 ++++++++++++--------
 mythtv/programs/mythbackend/services/content.cpp   |    1 +
 .../mythfrontend/gallerydatabasehelper.cpp         |    4 +-
 mythtv/programs/mythfrontend/gallerywidget.cpp     |    4 +-
 mythtv/programs/mythfrontend/themechooser.cpp      |    4 +-
 mythtv/programs/mythtranscode/main.cpp             |    3 +-
 14 files changed, 67 insertions(+), 42 deletions(-)

--