[mythtv-commits] Ticket #12308: Improve mythcommflag accuracy

[MythTV]

#12308: Improve mythcommflag accuracy
-----------------------------------+--------------------------
 Reporter:  faginbagin <mythtv@…>  |          Owner:  cpinkham
     Type:  Patch - Bug Fix        |         Status:  new
 Priority:  minor                  |      Milestone:  unknown
Component:  MythTV - Mythcommflag  |        Version:  0.27.4
 Severity:  medium                 |     Resolution:
 Keywords:                         |  Ticket locked:  0
-----------------------------------+--------------------------

Comment (by faginbagin <mythtv@…>):

 Replying to [comment:1 warpme@…]:
 > Hi,
 > I was trying to play with those patches - but unfortunately I'm
 receiving following error building on current master: (In fact I want to
 play with those patches on 0.27-fixes - but error is similar)
 >
 > {{{
 > g++ -c -m64 -pipe -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DPIC
 -fomit-frame-pointer -fPIC -msse -pthread -g -Wall -Wpointer-arit
 > h -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS -fvisibility-inlines-
 hidden -Wmissing-declarations -Wno-switch -Woverloaded-virtual
 >  -funit-at-a-time -D_REENTRANT -DMMX -D_GNU_SOURCE -DQT_NO_DEBUG
 -DQT_SQL_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_L
 > IB -DQT_SHARED -I/usr/share/qt/mkspecs/linux-g++-64 -I.
 -I/usr/include/QtCore -I/usr/include/QtNetwork -I/usr/include/QtGui
 -I/usr/i
 > nclude/QtXml -I/usr/include/QtSql -I/usr/include -I/usr/include -I/usr
 -I/usr/include/libxml2 -I../../external/qjson/include -I../..
 >  -I../../libs -I../../libs/libmyth -I../../libs/libmyth/audio
 -I../../libs/libmythtv -I../../external/FFmpeg -I../../libs/libmythupn
 > p -I../../libs/libmythui -I../../libs/libmythmetadata
 -I../../libs/libmythlivemedia -I../../libs/libmythbase
 -I../../external/libmyt
 > hdvdnav/dvdnav -I../../external/libmythdvdnav/dvdread
 -I../../external/libmythbluray -I../../external/libmythsoundtouch
 -I../../exte
 > rnal/libsamplerate -I../../libs/libmythtv/mpeg
 -I../../libs/libmythtv/vbitext -I../../libs/libmythservicecontracts
 -I../../libs/libm
 > ythprotoserver -I/usr/X11R6/include -I. -o Histogram.o Histogram.cpp
 > Histogram.cpp: In member function ‘void
 Histogram::generateFromImage(VideoFrame*, unsigned int, unsigned int,
 unsigned int, unsigned
 >  int, unsigned int, unsigned int, unsigned int, unsigned int)’:
 > Histogram.cpp:34:36: error: invalid use of incomplete type ‘VideoFrame
 {aka struct VideoFrame_}’
 > In file included from Histogram.cpp:1:0:
 > Histogram.h:4:16: error: forward declaration of ‘VideoFrame {aka struct
 VideoFrame_}’
 > Histogram.cpp:35:29: error: invalid use of incomplete type ‘VideoFrame
 {aka struct VideoFrame_}’
 > In file included from Histogram.cpp:1:0:
 > Histogram.h:4:16: error: forward declaration of ‘VideoFrame {aka struct
 VideoFrame_}’
 > make[2]: *** [Histogram.o] Error 1
 > make[2]: Leaving directory `/home/piotro/backend-dev/ABS/mythtv-
 master/src/mythtv-master-build/mythtv/programs/mythcommflag'
 > make[1]: *** [sub-mythcommflag-make_default] Error 2
 > make[1]: *** Waiting for unfinished jobs....
 > }}}

 I'm confused, did you get the same errors trying to compile against
 fixes/0.27? Or maybe you first tried compiling against master? There was a
 change in master where libmythv/frame.h was renamed to
 libmythtv/mythframe.h, but that hasn't been applied to fixes/0.27. My
 patches should compile without error on 0.27. On master, you probably need
 to make the changes George outlines.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12308#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center