[mythtv-commits] Ticket #12155: Do not allow subtitile to be set for manual recordings (was: Manual Recordings lose Subtitle)

[MythTV]

#12155: Do not allow subtitile to be set for manual recordings
----------------------------------+----------------------------
 Reporter:  billstei@…            |          Owner:  kormoc
     Type:  Bug Report - General  |         Status:  new
 Priority:  minor                 |      Milestone:  unknown
Component:  Plugin - MythWeb      |        Version:  0.27-fixes
 Severity:  low                   |     Resolution:
 Keywords:  scheduler subtitle    |  Ticket locked:  0
----------------------------------+----------------------------
Changes (by gigem):

 * status:  infoneeded_new => new
 * component:  MythTV - Scheduling => Plugin - MythWeb
 * owner:  gigem => kormoc
 * severity:  medium => low


Old description:

> When setting a manual recording the manually specified Subtitle is
> replaced incorrectly by the Startdate and Starttime and (re)placed into
> the "program" table.  This occurs on line #3313 of scheduler.cpp in the
> Scheduler::UpdateManuals() method with the following code:
>
> query.bindValue(":SUBTITLE", startdt.toLocalTime());
>
> I recommend that the query of the "record" table on line #3222 of
> scheduler.cpp include "subtitle" along with an additional line ~3236:
>
> QString subtitle = query.value(THE_VALUE_AFTER_TITLE).toString();
>
> A simple test for the bug can be done by setting the Recording Started
> System Event to the following:
>
> logger "The Subtitle is: %SUBTITLE%"
>
> and then checking /var/log/syslog for the correct subtitle.

New description:

 [Note the following original report was done with mythweb.  Specifying the
 subtitle for manual recordings is not supported in the backend and mythweb
 should not allow it.]

 When setting a manual recording the manually specified Subtitle is
 replaced incorrectly by the Startdate and Starttime and (re)placed into
 the "program" table.  This occurs on line #3313 of scheduler.cpp in the
 Scheduler::UpdateManuals() method with the following code:

 query.bindValue(":SUBTITLE", startdt.toLocalTime());

 I recommend that the query of the "record" table on line #3222 of
 scheduler.cpp include "subtitle" along with an additional line ~3236:

 QString subtitle = query.value(THE_VALUE_AFTER_TITLE).toString();

 A simple test for the bug can be done by setting the Recording Started
 System Event to the following:

 logger "The Subtitle is: %SUBTITLE%"

 and then checking /var/log/syslog for the correct subtitle.

--

Comment:

 Thanks for following up.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12155#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center