[mythtv-commits] Ticket #12141: Fields season/episode/totalepisodes sometimes missing

MythTV noreply at mythtv.org
Wed May 14 21:59:21 UTC 2014


#12141: Fields season/episode/totalepisodes sometimes missing
------------------------------+-----------------------------
 Reporter:  klaas.de.waal@…   |          Owner:
     Type:  Patch - Bug Fix   |         Status:  new
 Priority:  minor             |      Milestone:  unknown
Component:  MythTV - General  |        Version:  Master Head
 Severity:  low               |     Resolution:
 Keywords:  EPG xmltv guide   |  Ticket locked:  0
------------------------------+-----------------------------

Comment (by klaas.de.waal@…):

 The patch is only about updating the database table program (the guide)
 and not about the recordings so the complexities of how to carry the
 season/episode into the recording tables, described in comment 1 above,
 can be ignored for now.

 The patch however can be improved. In DBEvent::UpdateDB the patch
 unconditionally copies the new values for season/episode/totalepisodes
 into the database record. The existing code for the other fields is more
 careful; there is a check for null values on new data to avoid overwriting
 existing data. This check has now been added for the updates of fields
 season/episode/totalepisodes as well.

 Another minor change is the update of field airdate. The existing code
 only updates the field if the new value was null instead of doing the
 update when the new values is not null. The coding style for the field
 update is now the same as for the other integer fields.

 The patch will be attached; the complete source in programdata.cpp.v2 and
 the "git diff" in programdata.cpp.diff.v2.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12141#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list