[mythtv-commits] Ticket #12079: Attempt to play any rec. from LiveTV group segfaults FE

[MythTV]

#12079: Attempt to play any rec. from LiveTV group segfaults FE
--------------------------------+-----------------------------
 Reporter:  warpme@…            |          Owner:
     Type:  Bug Report - Crash  |         Status:  new
 Priority:  minor               |      Milestone:  unknown
Component:  MythTV - General    |        Version:  Master Head
 Severity:  medium              |     Resolution:
 Keywords:                      |  Ticket locked:  0
--------------------------------+-----------------------------

Comment (by jyavenard):

 There is no way 0.27 or devel/027candidates could have the crash you
 describe; the code just didn't exist there.

 What you need is either revert
 https://github.com/MythTV/mythtv/commit/7fd5ad119c73

 or replace line 1022
 {{{
         int cardid = player_ctx->recorder->GetRecorderNumber();
         QString channum = player_ctx->playingInfo->GetChanNum();
         QString inputname;
         int cardinputid = CardUtil::GetCardInputID(cardid, channum,
 inputname);
         CardUtil::SetStartChannel(cardinputid, channum);
 }}}

 with:
 {{{
         if (IsWatchingInprogress())
         {
             int cardid = player_ctx->recorder->GetRecorderNumber();
             QString channum = player_ctx->playingInfo->GetChanNum();
             QString inputname;
             int cardinputid = CardUtil::GetCardInputID(cardid, channum,
 inputname);
             CardUtil::SetStartChannel(cardinputid, channum);
         }
 }}}

 personally, I feel that a complete revert is better as it doesn't make
 sense to save the cardid at this stage

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12079#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center