[mythtv-commits] mythtv branch master updated by stuartm. v0.28-pre-1992-g4100e6e

[Git Repo Owner]

The branch, master has been updated on the
mythtv repository by gitolite user stuartm.
       via  4100e6e3d26607177e14c6e90fc95630b971f108 (commit)
       via  348a56cf0e7531ddb0b40f366fa012f887880c5f (commit)
       via  1869d982edd0c189b5ed8bb2155907afeafd2e89 (commit)
      from  547639274d6034daa5aa2722bfc1dd88394bbc77 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4100e6e3d26607177e14c6e90fc95630b971f108
Author:    Stuart Morgan <smorgan at mythtv.org> at Sat, 26 Jul 2014 12:57:18 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Sat, 26 Jul 2014 12:57:18 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=4100e6e3d26607177e14c6e90fc95630b971f108

Fix possible out of bounds array access in mythfilerecorder. Coverity 1213716



commit 348a56cf0e7531ddb0b40f366fa012f887880c5f
Author:    Stuart Morgan <smorgan at mythtv.org> at Sat, 26 Jul 2014 11:59:44 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Sat, 26 Jul 2014 12:29:49 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=348a56cf0e7531ddb0b40f366fa012f887880c5f

Move replex into an external subdirectory.



commit 1869d982edd0c189b5ed8bb2155907afeafd2e89
Author:    Stuart Morgan <smorgan at mythtv.org> at Sat, 26 Jul 2014 11:36:22 +0100
Committer: Stuart Morgan <smorgan at mythtv.org> at Sat, 26 Jul 2014 11:36:27 +0100
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=1869d982edd0c189b5ed8bb2155907afeafd2e89

Fix a number of theoretical memory leaks in MythStreamHandler.
Coverity 1213718

There were several points where we'd return early from
ExternIO::Fork() without freeing memory assigned early in the
method. Rather than repeating the same free/delete[] calls at each
point I just moved the assignments down so they occur after all the
possible return points, this works out fine since they weren't
actually used before then.

For this to actually leak in practice the fork and pipe calls would
have to fail which would be a rare event.



-----------------------------------------------------------------------

Summary of changes:
 .../libmythtv/recorders/ExternalStreamHandler.cpp  |   43 ++++++-----------
 mythtv/programs/mythfilerecorder/main.cpp          |   15 ++++--
 .../programs/mythtranscode/external/external.pro   |    7 +++
 .../mythtranscode/{ => external}/replex/.gitignore |    0
 .../mythtranscode/{ => external}/replex/CHANGES    |    0
 .../mythtranscode/{ => external}/replex/COPYING    |    0
 .../{ => external}/replex/Makefile.standalone      |    0
 .../mythtranscode/{ => external}/replex/README     |    0
 .../mythtranscode/{ => external}/replex/TODO       |    0
 .../mythtranscode/{ => external}/replex/avi.c      |    0
 .../mythtranscode/{ => external}/replex/avi.h      |    0
 .../mythtranscode/{ => external}/replex/element.c  |    0
 .../mythtranscode/{ => external}/replex/element.h  |    0
 .../{ => external}/replex/mpg_common.c             |    0
 .../{ => external}/replex/mpg_common.h             |    0
 .../{ => external}/replex/multiplex.c              |    0
 .../{ => external}/replex/multiplex.h              |    0
 .../mythtranscode/{ => external}/replex/pes.c      |    0
 .../mythtranscode/{ => external}/replex/pes.h      |    0
 .../mythtranscode/{ => external}/replex/replex.c   |    0
 .../mythtranscode/{ => external}/replex/replex.h   |    0
 .../mythtranscode/external/replex/replex.pro       |   50 ++++++++++++++++++++
 .../{ => external}/replex/ringbuffer.c             |    0
 .../{ => external}/replex/ringbuffer.h             |    0
 .../mythtranscode/{ => external}/replex/ts.c       |    0
 .../mythtranscode/{ => external}/replex/ts.h       |    0
 mythtv/programs/mythtranscode/mpeg2fix.h           |    4 +-
 mythtv/programs/mythtranscode/mythtranscode.pro    |   13 +++--
 mythtv/programs/mythtranscode/replex/replex.pro    |   50 --------------------
 mythtv/programs/programs.pro                       |    2 +-
 30 files changed, 93 insertions(+), 91 deletions(-)
 create mode 100644 mythtv/programs/mythtranscode/external/external.pro
 rename mythtv/programs/mythtranscode/{ => external}/replex/.gitignore (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/CHANGES (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/COPYING (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/Makefile.standalone (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/README (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/TODO (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/avi.c (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/avi.h (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/element.c (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/element.h (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/mpg_common.c (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/mpg_common.h (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/multiplex.c (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/multiplex.h (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/pes.c (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/pes.h (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/replex.c (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/replex.h (100%)
 create mode 100644 mythtv/programs/mythtranscode/external/replex/replex.pro
 rename mythtv/programs/mythtranscode/{ => external}/replex/ringbuffer.c (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/ringbuffer.h (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/ts.c (100%)
 rename mythtv/programs/mythtranscode/{ => external}/replex/ts.h (100%)
 delete mode 100644 mythtv/programs/mythtranscode/replex/replex.pro

--