[mythtv-commits] Ticket #12051: Fix CEA-608 preamble access codes that indent.

[MythTV]

#12051: Fix CEA-608 preamble access codes that indent.
-----------------------------------+----------------------------
 Reporter:  faginbagin <mythtv@…>  |          Owner:  stichnot
     Type:  Patch - Bug Fix        |         Status:  accepted
 Priority:  minor                  |      Milestone:  0.27.4
Component:  MythTV - Captions      |        Version:  0.27-fixes
 Severity:  medium                 |     Resolution:
 Keywords:                         |  Ticket locked:  0
-----------------------------------+----------------------------

Comment (by stichnot):

 Just for context, the 0x70nn characters are interpreted as spaces
 primarily so that backspace and tab processing can be handled simply
 (though I suspect tabs aren't currently correct).

 Back when this was first implemented in #9772, I was unhappy with the way
 preamble codes created an initial space character, which would show up
 against a black background when the background was enabled.  This was an
 ugliness shared by my STB's caption renderer.  This is why there is
 inconsistent treatment of these unicode characters.  However, I think
 later caption work turns leading spaces into an indent without background
 for all caption types.

 In any case, simply changing the assignment of limit to "int limit =
 newcol[mode];" seems to fix the indent problem, and I don't see any ill
 effects on other captions in the WGBH sample or other recordings.  Do you
 see any issues with that?

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12051#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center