[mythtv-commits] Ticket #12065: Qt5 feature patch to resolve X11/Xlib.h Bool define issue

[MythTV]

#12065: Qt5 feature patch to resolve X11/Xlib.h Bool define issue
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:
  <gary.buhrmaster@…>                            |     Status:  new
         Type:  Patch - Feature                  |  Milestone:  unknown
     Priority:  minor                            |    Version:  Master Head
    Component:  MythTV - Video Library           |   Keywords:  Qt5
     Severity:  medium                           |
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 Qt5 has been released, and some distros are starting to provide it as an
 alternative to Qt4, although I would not expect Qt5 to be the default for
 quite some time.  Regardless, one of the changes in Qt5 (5.2) is that in
 qjsonvalue.h there is an enum which includes a line of the form ".. Bool =
 0x1 ..".  Unfortunately, the X11/Xlib.h has a "#define Bool int" line,
 which results in the qjsonvalue enum looking like ".. int = 0x1 ..", which
 generates badness when Xlib.h is included before the appropriate Qt
 include (mythimage.h includes QImageReader.h which eventually includes
 qjsonobject.h and qjsonvalue.h).  This patch rearranges the includes in
 the impacted MythTV source files to bypass the issue and allows
 compilation to proceed.

 Github ref:
 https://github.com/garybuhrmaster/mythtv/commit/01d52e44ec41fb71bde841d2fbbbe248fe648272
 Github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/01d52e44ec41fb71bde841d2fbbbe248fe648272.patch

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12065>
MythTV <http://www.mythtv.org>
MythTV Media Center