[mythtv-commits] Ticket #12061: Music Mini Player restarts playback on an old saved position

[MythTV]

#12061: Music Mini Player restarts playback on an old saved position
------------------------------------+------------------------
     Reporter:  angela.schmid@…     |      Owner:
         Type:  Patch - Bug Fix     |     Status:  new
     Priority:  minor               |  Milestone:  unknown
    Component:  Plugin - MythMusic  |    Version:  0.27-fixes
     Severity:  low                 |   Keywords:
Ticket locked:  0                   |
------------------------------------+------------------------
 MusicPlayer saves positions only on a complete stop in the music dialogs
 or upon destroy.
 When in the music dialog exit is pressed with further play option, the
 MusicPlayer does not save its position.
 When the MiniPlayer dialog is opened, the player stopped and the
 MiniPlayer dialog is closed, then when the MiniPlayer dialog is opened
 again MusicCommon::CreateCommon is called and !gPlayer->isPlaying() is
 true, an old saved position is restored.

 !gPlayer->isPlaying() is normally used to start playback on entry of the
 music dialogs.

 With the “further play option” there exists a MusicPlayer instance and
 holds during all times a valid position, therefor when opening the
 MiniPlayer dialog (see MusicCommon::CreateCommon) does not have to
 reposition.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12061>
MythTV <http://www.mythtv.org>
MythTV Media Center