[mythtv-commits] Ticket #12003: Episode info not usable in templates in themes
MythTV
noreply at mythtv.org
Sat Dec 27 22:23:58 UTC 2014
#12003: Episode info not usable in templates in themes
--------------------------+------------------------------------------------
Reporter: thomas@… | Owner: Jonatan Lindblad <jlindblad@…>
Type: Patch - Bug | Status: closed
Fix |
Priority: minor | Milestone: 0.27.5
Component: Themes | Version: Unspecified
Severity: medium | Resolution: fixed
Keywords: | Ticket locked: 0
--------------------------+------------------------------------------------
Comment (by Frank Phillips <fphillips81@…>):
My problem is this commit causes the regex to capture parentheses because
we went from word chacters (\w) to any non-whitespace char (\S). This
creates a non-matching variable like "YEAR|)". Please revert this commit.
If it is necessary to keep them around in 0.27 branch, you can change
(\w+) to (\w+|##x##|s##e##).
To be specific, we are talking about the use of ##x##/s##e## as variables
in template text (and only in video-ui, for historical reasons). It is
documented in wiki:Video-ui.xml, but I doubt if this ever worked. The
regex hasn't changed since 2010 [96df30] and the map was created in 2012
[34b933]. Why enable it now, backed by the 00x00/s00e00 alternatives in
[d4e651]? The themes I have looked at only used ##x##/s##e## as textarea
name attributes, which don't use the regex. I don't know if there has been
any netvision/rss usage.
I've been using http://sourceforge.net/projects/qregexp-editor/ to
visualize the captures.
--
Ticket URL: <https://code.mythtv.org/trac/ticket/12003#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list