[mythtv-commits] Ticket #10080: Firewire MPEG4 Support

[MythTV]

#10080: Firewire MPEG4 Support
----------------------------------------+-----------------------------
 Reporter:  Andrew Phillips <theasp@…>  |          Owner:  danielk
     Type:  Patch - Bug Fix             |         Status:  new
 Priority:  minor                       |      Milestone:  unknown
Component:  MythTV - Recording          |        Version:  Master Head
 Severity:  medium                      |     Resolution:
 Keywords:                              |  Ticket locked:  0
----------------------------------------+-----------------------------
Changes (by adamw@…):

 * status:  closed => new
 * resolution:  Feature request without patch =>


Comment:

 How abut that patch? It adds MPEG-4 support and *reduces* the amount of
 unique code in FirewireRecorder, by re-using DTVRecorder's functions for
 processing TS packets.

 I couldn't manage to factor out FirewireRecorder::ProcessTSPacket
 entirely, but someone smarter probably could, I don't think it's
 impossible. I tried replacing the ProcessTSPacket calls in
 FirewireRecorder::AddData with calls to GetStreamData()->ProcessTSPacket
 but that doesn't work; I guess the bits in MPEGStreamData::ProcessTSPacket
 which figure out the function to call according to the available listeners
 don't work with inherited classes maybe? I dunno, this works.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/10080#comment:8>
MythTV <http://www.mythtv.org>
MythTV Media Center