[mythtv-commits] Ticket #12128: "Add ReadInternalMode to RingBuffer class" commit breaks editing

[MythTV]

#12128: "Add ReadInternalMode to RingBuffer class" commit breaks editing
--------------------------------------+-------------------------
     Reporter:  gnassas@…             |      Owner:
         Type:  Bug Report - General  |     Status:  new
     Priority:  minor                 |  Milestone:  unknown
    Component:  MythTV - General      |    Version:  Master Head
     Severity:  medium                |   Keywords:
Ticket locked:  0                     |
--------------------------------------+-------------------------
 I recently updated from late March master to recent (April 26) and editing
 stopped working for me.

 The symptom is the frame display no longer updates when you move around
 the recording. The frame and position numbers change but the frame stays
 the same. When you exit the edit you get the end of recording
 "keep/delete" dialog as if you were at the end of the recording even if
 you aren't.

 A bisect pointed the finger at the recent RingBuffer changes. The bisect
 output was:

 {{{
 c519bba367320a3773c093c30d05e1330534589c is the first bad commit
 commit c519bba367320a3773c093c30d05e1330534589c
 Author: Jean-Yves Avenard <jyavenard at mythtv.org>
 Date:   Sat Apr 26 17:31:36 2014 +1000

     Add ReadInternalMode to RingBuffer class

     This mode allows to limit the content of the ringbuffer to the content
 already loaded. Seeking, reading and other operations will not be
 destructive.
     This allows for almost instantaneous streams and bitrate detection.

     Duration calculated will obviously be wrong, but as the duration is
 stored in the DB we’ll use that duration instead anyway, meaning we only
 have to worry about streams detection itself.

     This greatly speed up liveTV transition change and playback startup

 :040000 040000 f7bc65ad6761416b61127aa9e987058f0e8463c3
 2cbb58487e13b39b373b08b006762ad33930e206 M      mythtv
 }}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12128>
MythTV <http://www.mythtv.org>
MythTV Media Center