[mythtv-commits] Ticket #11882: Attempt to play recording freezes frontend
MythTV
noreply at mythtv.org
Sat Oct 26 23:29:41 UTC 2013
#11882: Attempt to play recording freezes frontend
----------------------------------------+----------------------------
Reporter: warpme@… | Owner: stichnot
Type: Bug Report - Hang/Deadlock | Status: accepted
Priority: minor | Milestone: 0.27.1
Component: MythTV - Video Decoding | Version: 0.27-fixes
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------------+----------------------------
Comment (by stichnot):
Replying to [comment:6 blm-ubunet@…]:
> H264 decoding requires SPS first, just like mpeg2 requires SEQ header.
> SPS is also one type of keyframe.
If this is true, isn't the following patch more appropriate?
{{{
diff --git a/mythtv/libs/libmythtv/avformatdecoder.cpp
b/mythtv/libs/libmythtv/avformatdecoder.cpp
index 3a42b40..e9af99b 100644
--- a/mythtv/libs/libmythtv/avformatdecoder.cpp
+++ b/mythtv/libs/libmythtv/avformatdecoder.cpp
@@ -3152,7 +3152,8 @@ int AvFormatDecoder::H264PreProcessPkt(AVStream
*stream, AVPacket *pkt)
if (m_h264_parser->onFrameStart())
++num_frames;
- if (!m_h264_parser->onKeyFrameStart())
+ if (!m_h264_parser->onKeyFrameStart() &&
+ !m_h264_parser->seen_SPS())
continue;
}
else
}}}
--
Ticket URL: <http://code.mythtv.org/trac/ticket/11882#comment:7>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list