[mythtv-commits] Ticket #11905: HttpRequest parsing fails on parameters containing encoded & character

MythTV noreply at mythtv.org
Fri Oct 11 20:45:59 UTC 2013


#11905: HttpRequest parsing fails on parameters containing encoded & character
----------------------------------+--------------------------------------
     Reporter:  dev-team@…        |      Owner:
         Type:  Patch - Bug Fix   |     Status:  new
     Priority:  minor             |  Milestone:  0.27.1
    Component:  MythTV - General  |    Version:  0.27-fixes
     Severity:  medium            |   Keywords:  httprequest services api
Ticket locked:  0                 |
----------------------------------+--------------------------------------
 Using the services api, while attempting to get the artwork for a
 recording containing a & in the title the backend would always fail to
 serve the artwork.
 The sample http get request was
 http://master:6544/Content/GetImageFile?StorageGroup=Coverart&FileName=Eastbound+%26+Down+Season+4_coverart.jpg

 the current httprequest.cpp first decodes the entire substring after "?"
 and therefore converts '%26' to '&' then it passes it to the GetParameters
 method which now reads erroneously an extra parameter.
 GetParameters decodes each parameter name/value pair with
 fromPercentEncoding().

 Attached is a patch that simply removes the decoding of the entire
 substring and let GetParameter do the decoding properly.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11905>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list