[mythtv-commits] Ticket #11894: Patch: Prevent Services API from telling clients to allow Keep-Alive

MythTV noreply at mythtv.org
Tue Oct 8 20:25:12 UTC 2013


#11894: Patch: Prevent Services API from telling clients to allow Keep-Alive
---------------------------------------------+-----------------------------
 Reporter:  Bill Meek <keemllib@…>           |          Owner:
     Type:  Patch - Bug Fix                  |         Status:  new
 Priority:  minor                            |      Milestone:  unknown
Component:  MythTV - Services API - Backend  |        Version:  Master Head
 Severity:  medium                           |     Resolution:
 Keywords:                                   |  Ticket locked:  0
---------------------------------------------+-----------------------------
Changes (by Bill Meek <keemllib@…>):

 * status:  closed => new
 * resolution:  Won't Fix =>


Comment:

 Replying to [comment:1 dblain]:

 Thanks for the response.

 > The service API and for that matter the http server, since it shares the
 same code, does support persistent connections.  The connection is only
 closed if Keep-alive isn't set, or there is a problem with the connection.

 Sorry if I'm repeating things you already know. I'd
 suggest the second sentence here:

 http://tools.ietf.org/html/rfc2616#section-8.1.2.1

 says MythTV should return Close in it's responses because
 it knows it can't do persistent connections. No fair letting
 the client think that MythTV can.

 > I'm closing this ticket.  If you can provide a use case that shows an
 actual problem, then re-open the ticket with the details on how to
 recreate it.

 The use case I'm testing is for the MythTV Android Frontend project.
 I've attached two protocol captures. One with the existing HTTP header
 where the client asks MythTV to use Keep-Alive (and MythTV says OK by
 returning Keep-Alive.)  The second is with client side code modified to
 always ask for "Connection" "Close". The result is the same as the
 suggest patch. It lets the client ask for Keep-Alive and MythTV says no,
 Close. I believe the patch is the correct solution. Future versions
 of MythTV may allow persistent connections, per discussions seen on
 the Developer's channel, and the clients needn't change.

 To be honest, this is a low runner problem.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11894#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list