[mythtv-commits] Ticket #10772: Expired programs not moved to deleted recordings group

[MythTV]

#10772: Expired programs not moved to deleted recordings group
------------------------------+--------------------------------
 Reporter:  Ian Dall <ian@…>  |          Owner:
     Type:  Patch - Bug Fix   |         Status:  infoneeded_new
 Priority:  minor             |      Milestone:  unknown
Component:  MythTV - General  |        Version:  Unspecified
 Severity:  medium            |     Resolution:
 Keywords:                    |  Ticket locked:  0
------------------------------+--------------------------------

Comment (by ian@…):

 See comment 1. Ticket #10704 was about fixing a real functional problem of
 the disk filling up due to "deleted" recordings not really being deleted.
 This bug was apparently introduced by commit
 f78f9992d754390fa42f109e5139b8eaf224d076. I also noticed that commit
 didn't really implement what was apparently intended according to the
 commit message: "Change delete behaviour so that we always use the deleted
 recording group".

 I assumed that there was some reason for always using the deleted
 recordings group. I don't have a use case where this matters (perhaps
 refer to the originator of f78f9992d754390fa42f109e5139b8eaf224d076) but
 in anycase it does seem wrong that recordings made on a remote backend
 would have different rules than recordings made on the master backend.

 I don't understand (comment 4), "which is not what [the patch is]
 described as doing" - I though that was exactly what the patch was
 described as doing - but no matter.

 In summary, this was just an attempt to make the code do what appeared to
 be the original intent. I may have misunderstood the original intent and I
 don't have a strong opinion on whether recordings should go to the Deleted
 Recordings group first or not.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10772#comment:7>
MythTV <http://www.mythtv.org>
MythTV Media Center