[mythtv-commits] Ticket #11943: Feature patch for improved logging in tv_rec.cpp

[MythTV]

#11943: Feature patch for improved logging in tv_rec.cpp
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:  danielk
  <gary.buhrmaster@…>                            |     Status:  new
         Type:  Patch - Feature                  |  Milestone:  unknown
     Priority:  minor                            |    Version:  Master Head
    Component:  MythTV - Recording               |   Keywords:
     Severity:  medium                           |
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 This is a feature patch for improved logging in tv_rec.cpp.

 This patch is broken into two parts so that it may be more easily reviewed
 by the developers.

 The first patch provides for the log message to include the cardid (via
 the LOC macro) that is used for all other LOGs in the source file by
 making the load_profile function a member function which has access to the
 cardid.  The function is renamed to to LoadProfile to match the convention
 of other member functions, and the references are updated.

 *NOTE* that there is a missing part to the first patch.  The patch (as
 referenced) does not bump the ABI version.  Since this ticket may remain
 under review for some time, I did not want to end up accidentally
 colliding with some later patch, or make it harder to apply at some future
 point.  This results in a requirement for the developer who commits the
 patches to create a ABI bump patch.

 The second patch provides additional logging for the (new) LoadProfile
 function when certain failures and fallbacks are used, and may indicate a
 potential error condition.  The second patch depends on the first being
 applied.

 The patches have been (lightly) tested in my development environment and
 by directly manipulating my dev database to force some of the error
 messages to be logged.

 Thank you for consideration of this patch.


 Patch 1 - github ref:
 https://github.com/garybuhrmaster/mythtv/commit/15a771e144a6eae578bd7e030a40f9d0c3e0f5f5
 Patch 1 - github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/15a771e144a6eae578bd7e030a40f9d0c3e0f5f5.patch


 Patch 2 - github ref:
 https://github.com/garybuhrmaster/mythtv/commit/0562c6ae9ee056030efb22da2d07748ccf6bd697
 Patch 2 - github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/0562c6ae9ee056030efb22da2d07748ccf6bd697.patch

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11943>
MythTV <http://www.mythtv.org>
MythTV Media Center