[mythtv-commits] Ticket #11630: Path to properly handle fd number 0 in MythSystemLegacySignalManager

MythTV noreply at mythtv.org
Thu Jun 27 20:57:15 UTC 2013


#11630: Path to properly handle fd number 0 in MythSystemLegacySignalManager
-------------------------------------------------+-------------------------
 Reporter:  Gary Buhrmaster <gary.buhrmaster@…>  |           Type:  Patch -
   Status:  new                                  |  Bug Fix
Milestone:  unknown                              |       Priority:  minor
  Version:  Master Head                          |      Component:  MythTV
 Keywords:                                       |  - MythSystem
                                                 |       Severity:  medium
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------
 Visual analysis (IEAEYEBALL) detected that the check for the file
 descriptor value should be "fd >= 0" and not just "fd > 0".  While a fd of
 zero is commonly stdin, do the right check just in case.

 The CLOSE macro properly performs the check for greater than or equal to
 zero.  This patch just does the same thing inline.

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/397adce290af124050af7e431ac6cdd7a4afd650

 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/397adce290af124050af7e431ac6cdd7a4afd650.patch

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11630>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list