[mythtv-commits] Ticket #11627: Service API GetImageFile not handling '&' in file names

[MythTV]

#11627: Service API GetImageFile not handling '&' in file names
-------------------------------------+-------------------------------------
 Reporter:  r.d.vaughan@…            |           Type:  Bug Report -
   Status:  new                      |  General
Milestone:  unknown                  |       Priority:  minor
  Version:  0.26-fixes               |      Component:  MythTV - General
 Keywords:  Service API              |       Severity:  medium
  GetImageFile                       |  Ticket locked:  0
-------------------------------------+-------------------------------------
 Service API GetImageFile does not handle files with an embedded '&' even
 when escaped (e.g. "Law%20%26%20Order"). This presents an issue when the
 files are related with MythVideo records. Alternate Service API's
 associated with Recorded Artwork do not support screenshots and do not
 necessarily have records at all especially when entries in MythVideo were
 collected before Recorded Artwork metadata was supported.

 I am currently running a fully updated version of v0.26+fixes. I believe
 this problem is in every version that the Service API GetImageFile exists
 including master. The following information was extracted from a
 developer's IRC channel log, where bill6502 verified that the issue exists
 and made these relevant comments:

 <bill6502> IReboot: The proper escape for & is, in fact %26, but [ec50629]
 breaks it by doing fromPercentEncoding before it reaches:
 <bill6502> httprequest.cpp:904 (GetParameters) - sParams:
 'StorageGroup=fanart&FileName=Law%20%26%20Order:%20Special%20Victims%20Unit%20Season%201_fanart.jpg'
 <bill6502> so the %26 is replaced with & and whatever follows looks like
 another parameter.
 <bill6502> looks like the [] don't work, the commit is here:
 code.mythtv.org/trac/changeset/ec506292 reverting line 1027 fix the
 problem, but would likely bring back whatever it fixed.

 I labelled the component as the default "MythTV-General" as there is no
 obvious category for Service API.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11627>
MythTV <http://www.mythtv.org>
MythTV Media Center